Include mojo_main_{chromium,standalone}.cc instead of using a target

Make mojo_main_{chromium,standalone} a variable instead of a target

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275335

[DaveMoore, 2014-06-05 17:28:16]

Update comment

[darin (slow to review), 2014-06-05 18:02:47]

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:378: '<(mojo_main_standalone)',
why not just path/to/mojo_main_standalone.cc? wouldn't that be a lot easier to
read?

[jamesr, 2014-06-05 18:12:18]

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:378: '<(mojo_main_standalone)',
On 2014/06/05 18:02:47, darin wrote:
> why not just path/to/mojo_main_standalone.cc? wouldn't that be a lot easier to
> read?

+infinity.  using a gyp variable makes things really really complicated,
especially if the person making the application wants to do something else (like
define sources list in their own variable or in a gypi) where they have to start
fighting gyp variable expansion rules.  Just have people list out the source
file in the sources list.

[DaveMoore, 2014-06-05 20:16:35]

Remove variable, include full source

[DaveMoore, 2014-06-05 20:18:08]

Sort files

[DaveMoore, 2014-06-05 20:18:42]

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi
File mojo/mojo_examples.gypi (right):

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:378: '<(mojo_main_standalone)',
On 2014/06/05 18:12:18, jamesr wrote:
> On 2014/06/05 18:02:47, darin wrote:
> > why not just path/to/mojo_main_standalone.cc? wouldn't that be a lot easier
to
> > read?
> 
> +infinity.  using a gyp variable makes things really really complicated,
> especially if the person making the application wants to do something else
(like
> define sources list in their own variable or in a gypi) where they have to
start
> fighting gyp variable expansion rules.  Just have people list out the source
> file in the sources list.

Done.

https://codereview.chromium.org/316223002/diff/20001/mojo/mojo_examples.gypi#...
mojo/mojo_examples.gypi:378: '<(mojo_main_standalone)',
On 2014/06/05 18:02:47, darin wrote:
> why not just path/to/mojo_main_standalone.cc? wouldn't that be a lot easier to
> read?

Done.

[jamesr, 2014-06-05 20:19:43]

lgtm

[DaveMoore, 2014-06-05 20:24:30]

The CQ bit was checked by davemoore@chromium.org

[commit-bot: I haz the power, 2014-06-05 20:26:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davemoore@chromium.org/316223002/60001

[commit-bot: I haz the power, 2014-06-06 00:41:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-06 05:13:51]

Change committed as 275335