Ping? On Thu, Aug 26, 2010 at 5:48 PM, <erg@chromium.org> wrote: > Reviewers: Lei Zhang, ...
4 years, 9 months ago
(2010-08-27 19:37:14 UTC)
#2
Ping?
On Thu, Aug 26, 2010 at 5:48 PM, <erg@chromium.org> wrote:
> Reviewers: Lei Zhang,
>
> Description:
> FBTF: Move some heavy, repeatedly emitted symbols to implementation files.
>
> BUG=none
> TEST=compiles
>
> Please review this at http://codereview.chromium.org/3162047/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
> M app/app_paths.cc
> M app/gfx/gl/gl_implementation.cc
> M base/command_line.h
> M base/command_line.cc
> M base/process_util_unittest.cc
> M chrome/browser/prefs/command_line_pref_store.cc
> M chrome/browser/search_engines/template_url.h
> M chrome/browser/search_engines/template_url.cc
> M chrome/chrome_tests.gypi
> M chrome/nacl/nacl_main_platform_delegate_win.cc
> M chrome/renderer/renderer_main_platform_delegate_win.cc
> M chrome/test/test_launcher/out_of_proc_test_runner.cc
> M chrome/test/ui/ui_test_suite.cc
> M chrome/test/unit/chrome_test_suite.h
> A chrome/test/unit/chrome_test_suite.cc
> M chrome_frame/chrome_frame.gyp
>
>
>
LGTM http://codereview.chromium.org/3162047/diff/16001/17009 File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/3162047/diff/16001/17009#newcode126 chrome/chrome_tests.gypi:126: 'test/unit/chrome_test_suite.cc', unit comes after ui.
4 years, 9 months ago
(2010-08-27 19:58:18 UTC)
#3
Issue 3162047: FBTF: Move some heavy, repeatedly emitted symbols to implementation files.
(Closed)
Created 4 years, 9 months ago by Elliot Glaysher
Modified 4 years ago
Reviewers: Lei Zhang
Base URL: http://src.chromium.org/git/chromium.git
Comments: 1