Chromium Code Reviews
Help | Chromium Project | Sign in
(9)

Issue 3162047: FBTF: Move some heavy, repeatedly emitted symbols to implementation files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Elliot Glaysher
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, darin-cc_chromium.org, native-client-reviews_googlegroups.com, amit, John Grabowski, pam+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

FBTF: Move some heavy, repeatedly emitted symbols to implementation files. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57896

Patch Set 1 #

Patch Set 2 : Add forgotten file #

Patch Set 3 : win fixes #

Patch Set 4 : win fixes #

Patch Set 5 : more win fixes #

Patch Set 6 : fix app_paths #

Patch Set 7 : Fix windows interactive ui tests #

Patch Set 8 : Tested locally on windows #

Total comments: 1

Patch Set 9 : mac fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -175 lines) Patch
M app/app_paths.cc View 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M app/gfx/gl/gl_implementation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/command_line.h View 3 chunks +2 lines, -9 lines 0 comments Download
M base/command_line.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M base/process_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 1 2 3 2 chunks +5 lines, -20 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/sandbox_init_wrapper_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/nacl_main_platform_delegate_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/nacl_main_platform_delegate_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/test_launcher/out_of_proc_test_runner.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/ui_test_suite.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.h View 1 chunk +9 lines, -142 lines 0 comments Download
A chrome/test/unit/chrome_test_suite.cc View 1 chunk +163 lines, -0 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
4 years, 9 months ago (2010-08-27 00:48:17 UTC) #1
Elliot Glaysher
Ping? On Thu, Aug 26, 2010 at 5:48 PM, <erg@chromium.org> wrote: > Reviewers: Lei Zhang, ...
4 years, 9 months ago (2010-08-27 19:37:14 UTC) #2
Lei Zhang
4 years, 9 months ago (2010-08-27 19:58:18 UTC) #3
LGTM

http://codereview.chromium.org/3162047/diff/16001/17009
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/3162047/diff/16001/17009#newcode126
chrome/chrome_tests.gypi:126: 'test/unit/chrome_test_suite.cc',
unit comes after ui.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be