Run the cgpt tests in a separate directory.

Run the cgpt tests in a separate directory.

I'm getting ready to add a bunch more cgpt tests. This is just to clear the
way. 

Change-Id: I5cb781e85938b94da9c59528872ddfd386712726

[vb, 2010-08-19 23:15:33]

http://codereview.chromium.org/3162023/diff/1/2
File tests/common.sh (right):

http://codereview.chromium.org/3162023/diff/1/2#newcode8
tests/common.sh:8: SCRIPT_DIR=$(dirname $(readlink -f "$0"))
This is a noop change, right? 

It of course is a nice cleanup, but gnerally speaking should be a separate cl.

http://codereview.chromium.org/3162023/diff/1/3
File tests/run_cgpt_tests.sh (left):

http://codereview.chromium.org/3162023/diff/1/3#oldcode21
tests/run_cgpt_tests.sh:21: trap "rm -f ${DEV}" EXIT
so who's be cleaning up this stuff now?

[Randall Spangler, 2010-08-19 23:30:40]

http://codereview.chromium.org/3162023/diff/1/3
File tests/run_cgpt_tests.sh (left):

http://codereview.chromium.org/3162023/diff/1/3#oldcode21
tests/run_cgpt_tests.sh:21: trap "rm -f ${DEV}" EXIT
On 2010/08/19 23:15:35, vb wrote:
> so who's be cleaning up this stuff now?

(Are you leaving it around so you can run the tests manually afterwards?)

[gauravsh, 2010-08-19 23:34:47]

http://codereview.chromium.org/3162023/diff/1/2
File tests/common.sh (right):

http://codereview.chromium.org/3162023/diff/1/2#newcode8
tests/common.sh:8: SCRIPT_DIR=$(dirname $(readlink -f "$0"))
On 2010/08/19 23:15:35, vb wrote:
> This is a noop change, right? 
> 
> It of course is a nice cleanup, but gnerally speaking should be a separate cl.

FYI, The original complicated logic for determining script directory was added
by me because of the way autotest was invoking testing scripts - and yes it is
ugly. As it turns out, the only way to determine the script calling directory
that works in all cases is to use lsof. :)

Anyway, this was probably overkill and since we are now moving all autotests
into their associated git repositories, maybe needed any more.

Bill: Have you made sure this simplified logic handles the both of the
following:

./run_some_test

(while in some other directory)
/path/to/test/dir/run_some_test.sh

[Bill Richardson, 2010-08-19 23:59:34]

http://codereview.chromium.org/3162023/diff/1/2
File tests/common.sh (right):

http://codereview.chromium.org/3162023/diff/1/2#newcode8
tests/common.sh:8: SCRIPT_DIR=$(dirname $(readlink -f "$0"))
On 2010/08/19 23:34:47, gauravsh wrote:
> Bill: Have you made sure this simplified logic handles the both of the
> following:
> 
> ./run_some_test
> 
> (while in some other directory)
> /path/to/test/dir/run_some_test.sh

Yes. That's why I added it in the first place. The old way didn't work if I
started in the parent directory and said "./tests/run_cgpt_tests.sh
./build/cgpt/cgpt"

http://codereview.chromium.org/3162023/diff/1/3
File tests/run_cgpt_tests.sh (left):

http://codereview.chromium.org/3162023/diff/1/3#oldcode21
tests/run_cgpt_tests.sh:21: trap "rm -f ${DEV}" EXIT
Nobody's cleaning it up. The new directory sits inside the build directory,
which isn't cleaned up AFAIK except by portage. If you build manually, the whole
build directory is left around, which helps debug errors.

[Randall Spangler, 2010-08-20 00:02:20]

lgtm