Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 316193003: Fix some async repaint tests (Closed)

Created:
6 years, 6 months ago by Xianzhu
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke, enne (OOO)
CC:
blink-reviews
Visibility:
Public.

Description

Fix some async repaint tests Some async layout tests use waitUntilDone() and notifyDone() by themselves, without setting window.testIsAsync to true. This may be either unnecessary or incorrect, depending on which of the test's notifyDone() and text-based-repaint.js's notifyDone() executes first. If the latter executes first, the test may finish before it's done causing what the test want to test not fully executed. BUG=381242 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175599

Patch Set 1 #

Total comments: 1

Patch Set 2 : NeedsRebaseline more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -86 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/bugzilla-6473.html View 1 chunk +1 line, -12 lines 0 comments Download
M LayoutTests/fast/repaint/bugzilla-6473-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/crbug-371640.html View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/repaint/crbug-371640-2.html View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/repaint/crbug-371640-3.html View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/repaint/crbug-371640-4.html View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/repaint/repaint-during-scroll-with-zoom.html View 1 chunk +4 lines, -7 lines 0 comments Download
M LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/use-detach-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/mask-invalidation-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/svg/custom/foreignObject-crash-on-hover.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/mask-invalidation.svg View 2 chunks +2 lines, -5 lines 0 comments Download
M LayoutTests/svg/custom/resource-client-removal.svg View 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/svg/custom/resource-client-removal-expected.txt View 1 chunk +57 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/use-detach.svg View 2 chunks +2 lines, -5 lines 0 comments Download
M LayoutTests/svg/repaint/image-href-change.svg View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Xianzhu
6 years, 6 months ago (2014-06-05 18:04:26 UTC) #1
Xianzhu
https://codereview.chromium.org/316193003/diff/1/LayoutTests/fast/repaint/crbug-371640.html File LayoutTests/fast/repaint/crbug-371640.html (left): https://codereview.chromium.org/316193003/diff/1/LayoutTests/fast/repaint/crbug-371640.html#oldcode14 LayoutTests/fast/repaint/crbug-371640.html:14: testRunner.notifyDone(); This is unnecessary, because the repaint rects has ...
6 years, 6 months ago (2014-06-05 18:09:01 UTC) #2
enne (OOO)
lgtm. This is great! Thanks for cleaning all this up.
6 years, 6 months ago (2014-06-05 20:34:41 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-06-05 20:51:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/316193003/1
6 years, 6 months ago (2014-06-05 20:52:07 UTC) #5
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-06-05 22:00:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/316193003/20001
6 years, 6 months ago (2014-06-05 22:00:38 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 23:53:08 UTC) #8
Message was sent while issue was closed.
Change committed as 175599

Powered by Google App Engine
This is Rietveld 408576698