Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: Source/bindings/core/generated.gyp

Issue 316173008: IDL build: factor out global objects action into a GYP template (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/generated.gyp
diff --git a/Source/bindings/core/generated.gyp b/Source/bindings/core/generated.gyp
index 57a55548d3b4a5daed8e96a3f4d302b2bcdfe91f..25b18d663225a9e8dd0b15cb6ec9d280d5c15b1a 100644
--- a/Source/bindings/core/generated.gyp
+++ b/Source/bindings/core/generated.gyp
@@ -9,7 +9,6 @@
{
'includes': [
# ../.. == Source
- '../../bindings/bindings.gypi',
'../../bindings/scripts/scripts.gypi',
'../../core/core.gypi',
'core.gypi',
@@ -21,32 +20,11 @@
################################################################################
{
'target_name': 'core_global_objects',
Nils Barth (inactive) 2014/06/06 05:28:43 A bit simpler, no?
- 'type': 'none',
- 'actions': [{
- 'action_name': 'compute_core_global_objects',
- 'inputs': [
- '<(bindings_scripts_dir)/compute_global_objects.py',
- '<(bindings_scripts_dir)/utilities.py',
- # Only look in main IDL files (exclude dependencies and testing,
- # which should not define global objects).
- '<(core_idl_files_list)',
- '<@(core_idl_files)',
- ],
- 'outputs': [
- '<(bindings_core_output_dir)/GlobalObjectsCore.pickle',
- ],
- 'action': [
- 'python',
- '<(bindings_scripts_dir)/compute_global_objects.py',
- '--idl-files-list',
- '<(core_idl_files_list)',
- '--write-file-only-if-changed',
- '<(write_file_only_if_changed)',
- '--',
- '<(bindings_core_output_dir)/GlobalObjectsCore.pickle',
- ],
- 'message': 'Computing global objects in core',
- }]
+ 'variables': {
+ 'idl_files': '<(core_idl_files)',
+ 'output_file': '<(bindings_core_output_dir)/GlobalObjectsCore.pickle',
+ },
+ 'includes': ['../../bindings/scripts/global_objects.gypi'],
},
################################################################################
{

Powered by Google App Engine
This is Rietveld 408576698