Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
316173007:
Use ElementTraversal API in ContainerNode::checkForChildrenAdjacentRuleChanges() (Closed)
|
Created:
6 years, 6 months ago by Inactive Modified:
6 years, 6 months ago Reviewers:
esprehn CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionUse ElementTraversal API in ContainerNode::checkForChildrenAdjacentRuleChanges()
Use ElementTraversal API in ContainerNode::checkForChildrenAdjacentRuleChanges()
as we are only interested in child Elements.
R=esprehn@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175722
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rename to child #Messages
Total messages: 24 (0 generated)
lgtm https://codereview.chromium.org/316173007/diff/1/Source/core/dom/ContainerNod... File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/316173007/diff/1/Source/core/dom/ContainerNod... Source/core/dom/ContainerNode.cpp:1119: for (Element* childElement = ElementTraversal::firstChild(*this); childElement; childElement = ElementTraversal::nextSibling(*childElement)) { Just call it child, you don't need to rename it.
https://codereview.chromium.org/316173007/diff/1/Source/core/dom/ContainerNod... File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/316173007/diff/1/Source/core/dom/ContainerNod... Source/core/dom/ContainerNode.cpp:1119: for (Element* childElement = ElementTraversal::firstChild(*this); childElement; childElement = ElementTraversal::nextSibling(*childElement)) { On 2014/06/06 01:19:41, esprehn wrote: > Just call it child, you don't need to rename it. Done.
The CQ bit was checked by ch.dumez@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/316173007/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by ch.dumez@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/316173007/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by ch.dumez@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/316173007/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by esprehn@chromium.org
The CQ bit was checked by esprehn@chromium.org
The CQ bit was unchecked by esprehn@chromium.org
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/316173007/20001
Message was sent while issue was closed.
Change committed as 175722 |
