No longer limit SkPictureRecorder::partialReplay to Android

No longer limit SkPictureRecorder::partialReplay to Android

Toggling this for local testing is a bit of a chore.

Committed: https://skia.googlesource.com/skia/+/e2f2b984443e870319e107374f7d786f243a20ae

[mtklein, 2014-06-05 20:52:37]

lgtm

[reed1, 2014-06-05 20:57:33]

Is the long-term goal still to eliminate supporting partial replay?

[robertphillips, 2014-06-05 21:03:10]

Given Android's reliance on the Picture copy constructor I don't know if we can
(short of the years-long deprecation wait).

[reed1, 2014-06-05 21:11:36]

On 2014/06/05 21:03:10, robertphillips wrote:
> Given Android's reliance on the Picture copy constructor I don't know if we
can
> (short of the years-long deprecation wait).

ok lgtm

Have we actually deprecated whatever behavior we need to (at the Java level) to
start this process?

[robertphillips, 2014-06-08 14:25:50]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-06-08 14:28:22]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/robertphillips@google.com/316173004/1

[commit-bot: I haz the power, 2014-06-08 14:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-08 14:28:24]

Failed to apply patch for include/core/SkPictureRecorder.h:
While running git apply --index -p1;
  error: patch failed: include/core/SkPictureRecorder.h:66
  error: include/core/SkPictureRecorder.h: patch does not apply

Patch:       include/core/SkPictureRecorder.h
Index: include/core/SkPictureRecorder.h
diff --git a/include/core/SkPictureRecorder.h b/include/core/SkPictureRecorder.h
index
b496aee28e25e54b7239135ff5700eb5d9926156..39ac26501b2334c00c4439d6a28afa706177c7e5
100644
--- a/include/core/SkPictureRecorder.h
+++ b/include/core/SkPictureRecorder.h
@@ -66,14 +66,12 @@ public:
     }
 
 private:
-#ifdef SK_BUILD_FOR_ANDROID
     /** Replay the current (partially recorded) operation stream into
         canvas. This call doesn't close the current recording.
     */
     friend class AndroidPicture;
     friend class SkPictureRecorderReplayTester; // for unit testing
     void partialReplay(SkCanvas* canvas) const;
-#endif
 
     SkAutoTUnref<SkPicture>         fPicture;

[robertphillips, 2014-06-08 19:41:47]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-06-08 19:42:13]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/316173004/2...

[commit-bot: I haz the power, 2014-06-08 20:12:49]

Change committed as e2f2b984443e870319e107374f7d786f243a20ae