Handle "//# sourceURL" comments in the Parser instead of the JS.

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/api.h"
 #include "src/ast.h"
 #include "src/bootstrapper.h"
 #include "src/char-predicates-inl.h"
@@ skipping 873 matching lines @@
     ParsingModeScope parsing_mode(this, mode);
 
     // Enters 'scope'.
     FunctionState function_state(&function_state_, &scope_, scope, zone());
 
     scope_->SetStrictMode(info->strict_mode());
     ZoneList<Statement*>* body = new(zone()) ZoneList<Statement*>(16, zone());
     bool ok = true;
     int beg_pos = scanner()->location().beg_pos;
     ParseSourceElements(body, Token::EOS, info->is_eval(), true, &ok);
+
+    if (scanner()->HasSourceMapComment()) ParseSourceMapComment();
+
     if (ok && strict_mode() == STRICT) {
       CheckOctalLiteral(beg_pos, scanner()->location().end_pos, &ok);
     }
 
     if (ok && allow_harmony_scoping() && strict_mode() == STRICT) {
       CheckConflictingVarDeclarations(scope_, &ok);
     }
 
     if (ok && info->parse_restriction() == ONLY_SINGLE_FUNCTION_LITERAL) {
       if (body->length() != 1 ||
@@ skipping 2924 matching lines @@
   // Register that a break target found at the given stop in the
   // target stack has been used from the top of the target stack. Add
   // the break target to any TargetCollectors passed on the stack.
   for (Target* t = target_stack_; t != stop; t = t->previous()) {
     TargetCollector* collector = t->node()->AsTargetCollector();
     if (collector != NULL) collector->AddTarget(target, zone());
   }
 }
 
 
+void Parser::ParseSourceMapComment() {
+  Handle<String> source_map_comment =
+      scanner()->AllocateInternalizedSourceMapComment(isolate());
+  int value_start = 0, value_end = 0;
+  {
+    DisallowHeapAllocation no_gc;  // flat_data needs to stay alive.
+    String::FlatContent flat_data = source_map_comment->GetFlatContent();
+    if (!flat_data.IsAscii())
+      return;
+    Vector<const uint8_t> data = flat_data.ToOneByteVector();
+    // Parse the following: \s*name\s*=\s*value\s*.*
+    int name_start = 0;
+    while (name_start < data.length() && data[name_start] == ' ') {

[yurys, 2014/06/05 13:55:21]

This won't work for \tname=. Also the original pattern assumed exactly one
whitespace character between @ and sourceURL

+      ++name_start;
+    }
+    int name_end = name_start;
+    while (name_end < data.length() && data[name_end] != ' ' &&
+           data[name_end] != '=') {
+      ++name_end;
+    }
+    value_start = name_end;
+    while (value_start < data.length() && data[value_start] == ' ') {

[yurys, 2014/06/05 13:55:21]

Same here, the original pattern was [\040\t]sourceURL=[\040\t]*

+      ++value_start;
+    }
+    if (value_start >= data.length() || data[value_start] != '=') {
+      return;
+    }
+    ++value_start;  // Skip '='
+    while (value_start < data.length() && data[value_start] == ' ') {
+      ++value_start;
+    }
+    value_end = value_start;
+    while (value_end < data.length() && data[value_end] != ' ') {
+      ++value_end;
+    }
+    Vector<const uint8_t> name = data.SubVector(name_start, name_end);
+    if (!name.IsEqualTo(STATIC_ASCII_VECTOR("sourceURL"))) {
+      return;
+    }
+  }
+  info_->script()->set_source_url(*(isolate()->factory()->NewSubString(
+      source_map_comment, value_start, value_end)));
+}
+
+
 void Parser::ThrowPendingError() {
   if (has_pending_error_) {
     MessageLocation location(script_,
                              pending_error_location_.beg_pos,
                              pending_error_location_.end_pos);
     Factory* factory = isolate()->factory();
     bool has_arg =
         !pending_error_arg_.is_null() || pending_error_char_arg_ != NULL;
     Handle<FixedArray> elements = factory->NewFixedArray(has_arg ? 1 : 0);
     if (!pending_error_arg_.is_null()) {
@@ skipping 933 matching lines @@
       ASSERT(info()->isolate()->has_pending_exception());
     } else {
       result = ParseProgram();
     }
   }
   info()->SetFunction(result);
   return (result != NULL);
 }
 
 } }  // namespace v8::internal