Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 316153002: DevTools: Polish uiSourceCode context menu on sources panel. (Closed)

Created:
6 years, 6 months ago by vsevik
Modified:
6 years, 6 months ago
Reviewers:
apavlov, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Polish uiSourceCode context menu on sources panel. BUG=378942 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175866

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M Source/devtools/front_end/sources/NavigatorView.js View 1 2 chunks +16 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
vsevik
PTAL
6 years, 6 months ago (2014-06-05 11:54:44 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/316153002/diff/1/Source/devtools/front_end/sources/NavigatorView.js File Source/devtools/front_end/sources/NavigatorView.js (right): https://codereview.chromium.org/316153002/diff/1/Source/devtools/front_end/sources/NavigatorView.js#newcode365 Source/devtools/front_end/sources/NavigatorView.js:365: contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Delete" : "Delete"), this._handleContextMenuDelete.bind(this, uiSourceCode)); WebInspector.useLowerCaseMenuTitles() ...
6 years, 6 months ago (2014-06-06 16:26:19 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-06 16:28:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/316153002/10001
6 years, 6 months ago (2014-06-06 16:29:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 17:35:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:37:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7182)
6 years, 6 months ago (2014-06-06 17:37:55 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-10 05:31:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/316153002/30001
6 years, 6 months ago (2014-06-10 05:32:06 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 06:37:59 UTC) #10
Message was sent while issue was closed. 
Change committed as 175866

Powered by Google App Engine
This is Rietveld 408576698