Issue 316113002: Explicitly cast from HarfBuzz type to shorter type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316113002: Explicitly cast from HarfBuzz type to shorter type (Closed)

Created:
6 years, 6 months ago by ckocagil

Modified:
6 years, 6 months ago

Reviewers:
efidler1, eae

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Explicitly cast from HarfBuzz type to shorter type This allows the file to be compiled with C++11. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175606

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/platform/fonts/harfbuzz/HarfBuzzFaceSkia.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

efidler1

LGTM. The hb_codepoint_t's in the kerning callbacks are actually glyph id's so the cast should ...

6 years, 6 months ago (2014-06-05 14:04:07 UTC) #3

eae

On 2014/06/05 14:04:07, efidler1 wrote: > LGTM. The hb_codepoint_t's in the kerning callbacks are actually ...

6 years, 6 months ago (2014-06-05 16:04:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/316113002/1

6 years, 6 months ago (2014-06-05 23:23:34 UTC) #6

Message was sent while issue was closed.

Change committed as 175606