Read multi-install chrome's channel from the binaries.

Read multi-install chrome's channel from the binaries.

BUG=380828
R=robertshield@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274909

[robertshield, 2014-06-04 21:10:13]

LGTM w/minor nits

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
File chrome/installer/util/google_update_settings.cc (right):

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:153: multi_install = true;
do we need this local var, can we call is_multi_install() again below instead?

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
File chrome/installer/util/google_update_settings_unittest.cc (right):

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings_unittest.cc:357:
EXPECT_STREQ(L"dev-m", channel.c_str());
optional: test also that a non-empty value for the chrome product and an empty
value for the multi, the multi still wins.

[grt (UTC plus 2), 2014-06-04 21:15:35]

thank you, sir.

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
File chrome/installer/util/google_update_settings.cc (right):

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:153: multi_install = true;
On 2014/06/04 21:10:14, robertshield wrote:
> do we need this local var, can we call is_multi_install() again below instead?

removed

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
File chrome/installer/util/google_update_settings_unittest.cc (right):

https://codereview.chromium.org/316103002/diff/1/chrome/installer/util/google...
chrome/installer/util/google_update_settings_unittest.cc:357:
EXPECT_STREQ(L"dev-m", channel.c_str());
On 2014/06/04 21:10:14, robertshield wrote:
> optional: test also that a non-empty value for the chrome product and an empty
> value for the multi, the multi still wins. 

Done.

[robertshield, 2014-06-04 21:17:14]

LGTM++

[grt (UTC plus 2), 2014-06-04 21:24:50]

Committed patchset #2 manually as r274909 (presubmit successful).