Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: factory/chromium_commands.py

Issue 3161017: Final changes to get PyAuto official happy with Mac and Win. Use... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/buildbot/scripts/master/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | factory/chromium_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: factory/chromium_commands.py
===================================================================
--- factory/chromium_commands.py (revision 56043)
+++ factory/chromium_commands.py (working copy)
@@ -550,9 +550,11 @@
J = self.PathJoin
pyauto_script = J('src', 'chrome', 'test', 'functional',
'pyauto_functional.py')
- # in case a '..' prefix is needed
- if functional_base:
- pyauto_script = J(functional_base, pyauto_script)
+ # Mapping from self._target_platform to the name of the
+ # extracted chrome-*.zip
+ platmap = {'win32': 'chrome-win32',
+ 'darwin': 'chrome-mac',
+ 'linux2': 'chrome-linux' }
pyauto_functional_cmd = ['python', pyauto_script, '-v']
if self._target_platform == 'win32': # win needs python24
@@ -563,7 +565,7 @@
self.AddTestStep(retcode_command.ReturnCodeCommand,
test_name,
pyauto_functional_cmd,
- env={'PYTHONPATH': '.'},
+ env={'PYTHONPATH': platmap[self._target_platform]},
workdir=workdir,
timeout=timeout)
« no previous file with comments | « no previous file | factory/chromium_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698