Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 316093005: test_runner: Migrate MockWebRTCPeerConnectionHandler to Chromium C++ style (Closed)

Created:
6 years, 6 months ago by Nikhil
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

test_runner: Migrate MockWebRTCPeerConnectionHandler to Chromium C++ style Changes: 1) Run clang-format through source and header files. 2) Fix member variables names. 3) Rename file name to mock_webrtc_peer_connection_handler. 4) Fix parameter names. Updated mock_webrtc_data_channel_handler to remove assert and add parameter names. BUG=360000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275127

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Messages

Total messages: 6 (0 generated)
Nikhil
PTAL. Thanks!
6 years, 6 months ago (2014-06-05 08:06:24 UTC) #1
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/316093005/diff/1/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h File content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h (right): https://codereview.chromium.org/316093005/diff/1/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h#newcode27 content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h:27: MockWebRTCPeerConnectionHandler(blink::WebRTCPeerConnectionHandlerClient* client, please clang-format so the ...
6 years, 6 months ago (2014-06-05 08:26:52 UTC) #2
Nikhil
Review comments incorporated. https://codereview.chromium.org/316093005/diff/1/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h File content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h (right): https://codereview.chromium.org/316093005/diff/1/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h#newcode27 content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h:27: MockWebRTCPeerConnectionHandler(blink::WebRTCPeerConnectionHandlerClient* client, On 2014/06/05 08:26:52, jochen ...
6 years, 6 months ago (2014-06-05 08:57:43 UTC) #3
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 6 months ago (2014-06-05 08:57:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/316093005/20001
6 years, 6 months ago (2014-06-05 08:59:13 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 15:09:14 UTC) #6
Message was sent while issue was closed.
Change committed as 275127

Powered by Google App Engine
This is Rietveld 408576698