Issue 316083002: Add support for multiple roots to the client lib.

Issue 316083002: Add support for multiple roots to the client lib. (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for multiple roots to the client lib. R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275307

Patch Set 6 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -90 lines)			Patch
M	mojo/examples/embedded_app/embedded_app.cc	View	1 2 3 4	2 chunks	+20 lines, -5 lines	0 comments	Download
M	mojo/examples/sample_view_manager_app/sample_view_manager_app.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/examples/window_manager/window_manager.cc	View	1 2 3 4	3 chunks	+13 lines, -3 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager.cc	View	1 2 3 4	3 chunks	+8 lines, -11 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_private.h	View	1 2 3 4	2 chunks	+2 lines, -5 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_private.cc	View	1 2 3 4 5	1 chunk	+49 lines, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	1 2 3 4	2 chunks	+5 lines, -7 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_tree_node.cc	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc	View	1 2 3 4	22 chunks	+63 lines, -50 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/view_manager.h	View	1 2 3 4	1 chunk	+9 lines, -8 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/view_tree_node.h	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/316083002/diff/80001/mojo/services/public/cpp/view_manager/lib/view_manager_private.cc File mojo/services/public/cpp/view_manager/lib/view_manager_private.cc (right): https://codereview.chromium.org/316083002/diff/80001/mojo/services/public/cpp/view_manager/lib/view_manager_private.cc#newcode29 mojo/services/public/cpp/view_manager/lib/view_manager_private.cc:29: ViewTreeNodePrivate(root_).view_manager()).RemoveRoot(root_); nit: indent 1 more.

6 years, 6 months ago (2014-06-05 18:18:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/316083002/100001

6 years, 6 months ago (2014-06-05 20:20:04 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 6 months ago (2014-06-06 02:22:51 UTC) #5

Ben Goodger (Google)

6 years, 6 months ago (2014-06-06 02:59:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 manually as r275307 (presubmit successful).

Expand Messages | Collapse Messages