Use vertex attribute for text color in GrBitmapTextContext to make batching more likely

Use vertex attribute for text color in GrBitmapTextContext

Committed: https://skia.googlesource.com/skia/+/594069f0fe63c50cd6b176e218e04f381cc30182

[bsalomon, 2014-06-04 20:01:58]

https://codereview.chromium.org/316063002/diff/1/src/gpu/GrBitmapTextContext.cpp
File src/gpu/GrBitmapTextContext.cpp (right):

https://codereview.chromium.org/316063002/diff/1/src/gpu/GrBitmapTextContext....
src/gpu/GrBitmapTextContext.cpp:106: } else if
(!GrPixelConfigIsAlphaOnly(fCurrTexture->config())) {
Should this be kA888_GrMaskFormat == fStrike->getMaskFormat()?

I was a little confused by the mix of GrPixelConfig/GrMaskFormat checks. I ask
because I use kA8_GrMaskFormat in drawPackedGlyph below.

[jvanverth1, 2014-06-05 16:52:13]

lgtm + 1 comment

https://codereview.chromium.org/316063002/diff/1/src/gpu/GrBitmapTextContext.cpp
File src/gpu/GrBitmapTextContext.cpp (right):

https://codereview.chromium.org/316063002/diff/1/src/gpu/GrBitmapTextContext....
src/gpu/GrBitmapTextContext.cpp:106: } else if
(!GrPixelConfigIsAlphaOnly(fCurrTexture->config())) {
On 2014/06/04 20:01:58, bsalomon wrote:
> Should this be kA888_GrMaskFormat == fStrike->getMaskFormat()?
> 
> I was a little confused by the mix of GrPixelConfig/GrMaskFormat checks. I ask
> because I use kA8_GrMaskFormat in drawPackedGlyph below.

I think they're equivalent, but I agree to be consistent it should be
kA8_GrMaskFormat != fStrike->getMaskFormat().

[bsalomon, 2014-06-05 21:23:03]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-06-05 21:23:54]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/316063002/20001

[commit-bot: I haz the power, 2014-06-06 13:16:37]

Change committed as 594069f0fe63c50cd6b176e218e04f381cc30182