MacViews: Allow ui::EventLocationFromNative to handle native titlebars

MacViews: Allow ui::EventLocationFromNative to handle native titlebars

Currently EventLocationFromNative on mac only properly handles events in
windows with no native window border because it flips coordinate systems
using the entire NSWindow frame.

This change flips coordinates in the window's contentRect instead.

BUG=366021
TEST=Added: events_unittests EventsMacTest.NativeTitlebarEventLocation

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275380

[tapted, 2014-06-05 07:33:35]

sadrul: for review/OWNERS
rsesek: for Mac expertise

Thanks!

https://codereview.chromium.org/316053008/diff/20001/ui/events/cocoa/events_m...
File ui/events/cocoa/events_mac.mm (right):

https://codereview.chromium.org/316053008/diff/20001/ui/events/cocoa/events_m...
ui/events/cocoa/events_mac.mm:98: }
Note most of my local branches have been using a "ui/gfx/mac/point_utils.mm".
I'm not yet sure if it will be widely used, so haven't tried to land it. But
it's another possible approach for this stuff. Example in another CL:
https://codereview.chromium.org/303543004/diff/20001/ui/gfx/mac/point_utils.mm 

e.g. we could put a function in ui/gfx which was like

gfx::Point WindowPointFromNSPoint(NSWindow* window, const NSPoint& point) {
  if (!window)
    return ScreenPointFromNSPoint(point);
  NSRect content_rect = [window contentRectForFrameRect:[window frame]];
  return gfx::Point(location.x, NSHeight(content_rect) - location.y);
}

and here do

return gfx::WindowPointFromNSPoint([native_event window],
                                   [native_event locationInWindow]);

let me know if that approach sounds better.

[Robert Sesek, 2014-06-05 14:08:26]

LGTM

https://codereview.chromium.org/316053008/diff/20001/ui/events/cocoa/events_m...
File ui/events/cocoa/events_mac.mm (right):

https://codereview.chromium.org/316053008/diff/20001/ui/events/cocoa/events_m...
ui/events/cocoa/events_mac.mm:98: }
On 2014/06/05 07:33:35, tapted wrote:
> Note most of my local branches have been using a "ui/gfx/mac/point_utils.mm".
> I'm not yet sure if it will be widely used, so haven't tried to land it. But
> it's another possible approach for this stuff. Example in another CL:
> https://codereview.chromium.org/303543004/diff/20001/ui/gfx/mac/point_utils.mm

> 
> e.g. we could put a function in ui/gfx which was like
> 
> gfx::Point WindowPointFromNSPoint(NSWindow* window, const NSPoint& point) {
>   if (!window)
>     return ScreenPointFromNSPoint(point);
>   NSRect content_rect = [window contentRectForFrameRect:[window frame]];
>   return gfx::Point(location.x, NSHeight(content_rect) - location.y);
> }
> 
> and here do
> 
> return gfx::WindowPointFromNSPoint([native_event window],
>                                    [native_event locationInWindow]);
> 
> let me know if that approach sounds better.

I think I like extracting this information directly from the NSEvent better than
requiring the caller to pass the window.

[sadrul, 2014-06-05 15:56:43]

rslgtm

[tapted, 2014-06-05 23:12:38]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-06-05 23:15:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/316053008/20001

[commit-bot: I haz the power, 2014-06-06 10:35:57]

Change committed as 275380