Navigation transitions: Added notifyTransitionsShown and setupTransitionsView to WebLocalFrame

public/web/WebFrame.h

Index: public/web/WebFrame.h
diff --git a/public/web/WebFrame.h b/public/web/WebFrame.h
index d630f801834c1614177372f90fccbcb1fbaf5bcd..37152679367e69c24659ca44946dca3ef8971b63 100644
--- a/public/web/WebFrame.h
+++ b/public/web/WebFrame.h
@@ -471,6 +471,8 @@ public:
     virtual void extendSelectionAndDelete(int before, int after) = 0;
 
     virtual void addStyleSheetByURL(const WebString& url) = 0;
+    virtual void notifyTransitionShown(int elementsToHide) = 0;
+    virtual void setupTransitionView(const WebString& markup) = 0;

[abarth-chromium, 2014/06/13 17:29:01]

I'm not sure this is the right way to load this content into the frame.

Rather than replacing the content of the document (always dicey), you should
trigger a navigation of the frame to a new document with replacement data
consisting of your markup.  Specifically, I think you want to call something
like WebFrame::loadHTMLString.  Perhaps a function like
WebFrame::loadTransitionHTML that calls WebFrame::loadData under the hood, like
WebFrame::loadHTMLString calls WebFrame::loadData?  Notice that
WebFrame::loadData loads the data via the FrameLoader so that the rest of the
system works correctly.

[dcheng, 2014/06/18 18:12:17]

I don't think you'd ever want to call this on a remote frame? As such, I think
it'd be more appropriate to only add this API to WebLocalFrame.h.

[oystein (OOO til 10th of July), 2014/06/18 23:37:42]

Done.

[oystein (OOO til 10th of July), 2014/06/18 23:37:42]

Done! Right now I just call loadData() from setupTransitionView() though, should
it be moved to some intermediate function?

 
     virtual void setCaretVisible(bool) = 0;