Navigation transitions: Added notifyTransitionsShown and setupTransitionsView to WebLocalFrame

Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1315 matching lines @@
 {
     RefPtrWillBeRawPtr<Element> styleElement = frame()->document()->createElement(HTMLNames::linkTag, false);
 
     styleElement->setAttribute(HTMLNames::typeAttr, "text/css");
     styleElement->setAttribute(HTMLNames::relAttr, "stylesheet");
     styleElement->setAttribute(HTMLNames::hrefAttr, url);
 
     frame()->document()->head()->appendChild(styleElement.release(), IGNORE_EXCEPTION);
 }
 
+void WebLocalFrameImpl::notifyTransitionShown(int elementsToHide)

[abarth-chromium, 2014/06/21 05:38:36]

Perhaps this function should be called "beginExitTransition" ?

[oystein (OOO til 10th of July), 2014/07/22 21:17:21]

Done.

+{
+    frame()->loader().closeURL();
+
+    if (elementsToHide >= 0)
+        frame()->document()->hideTransitionElements((unsigned)elementsToHide);

[abarth-chromium, 2014/06/21 05:38:36]

Why randomly cast from signed to unsigned?  Will anyone ever call this function
with a negative number?

+    frame()->document()->setIsTransitionDocument();
+    frame()->document()->styleEngine()->enableExitTransitionStylesheets();
+}
+
+void WebLocalFrameImpl::setupTransitionView(const WebData& markup)
+{
+    // Need this so that the transition UA stylesheet gets applied.
+    frame()->document()->setIsTransitionDocument();
+
+    ASSERT(document().securityOrigin().isUnique());
+    frame()->document()->enforceSandboxFlags(SandboxAll);
+
+    loadData(markup, WebString::fromUTF8("text/html"), WebString::fromUTF8("UTF-8"), document().url(), WebURL(), true);
+}

[abarth-chromium, 2014/06/21 05:38:36]

These all seem like separate steps that the embedder should perform.

[oystein (OOO til 10th of July), 2014/07/22 21:17:21]

I moved the setIsTransitionDocument to a separate API function now, and renamed
this one navigateToSandboxedMarkup.

+
 void WebLocalFrameImpl::setCaretVisible(bool visible)
 {
     frame()->selection().setCaretVisible(visible);
 }
 
 VisiblePosition WebLocalFrameImpl::visiblePositionForWindowPoint(const WebPoint& point)
 {
     // FIXME(bokan): crbug.com/371902 - These scale/pinch transforms shouldn't
     // be ad hoc and explicit.
     PinchViewport& pinchViewport = frame()->page()->frameHost().pinchViewport();
@@ skipping 603 matching lines @@
 {
     RefPtr<LocalFrame> frame = LocalFrame::create(&m_frameLoaderClientImpl, host, owner);
     setWebCoreFrame(frame);
     frame->tree().setName(name, fallbackName);
     // May dispatch JS events; frame may be detached after this.
     frame->init();
     return frame;
 }
 
 } // namespace blink