Navigation transitions: Added notifyTransitionsShown and setupTransitionsView to WebLocalFrame

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 5698 matching lines @@
     m_taskRunner->postTask(AutofocusTask::create());
 }
 
 Element* Document::activeElement() const
 {
     if (Element* element = treeScope().adjustedFocusedElement())
         return element;
     return body();
 }
 
+void Document::hideTransitionElements(unsigned elementsToHide)
+{
+    unsigned currentValidTransitionElementsTag = 0;
+    for (HTMLMetaElement* metaElement = head() ? Traversal<HTMLMetaElement>::firstChild(*head()) : 0; metaElement; metaElement = Traversal<HTMLMetaElement>::nextSibling(*metaElement)) {
+        if (metaElement->name() != "transition-elements")
+            continue;
+
+        Vector<String> tokens;
+        metaElement->content().string().split(';', tokens);
+        if (tokens.size() != 2)
+            continue;
+
+        TrackExceptionState exceptionState;
+        RefPtr<NodeList> nodeList = querySelectorAll(AtomicString(tokens[0]), exceptionState);
+        if (nodeList && !exceptionState.hadException()) {
+            unsigned nodeListLength = nodeList->length();
+            if (!nodeListLength || elementsToHide != currentValidTransitionElementsTag++)
+                continue;

[abarth-chromium, 2014/06/21 05:38:36]

What if the meta tag has changed since the caller selected |elementsToHide|. 
Wouldn't it make more sense to read the meta element once and then operate on
the contents instead of passing around a numerical reference to a moving target.

[oystein (OOO til 10th of July), 2014/07/22 21:17:21]

I've changed this to just pass around the CSS selector string used instead of a
numerical index, should be more robust. The main issue is that Blink doesn't
know which set of transition elements should be hidden; Chrome is essentially
choosing which set to use based on something CSP-like

+
+            for (unsigned nodeIdx = 0; nodeIdx < nodeListLength; ++nodeIdx) {

[abarth-chromium, 2014/06/21 05:38:36]

nodeIndex

[oystein (OOO til 10th of July), 2014/07/22 21:17:21]

Done.

+                Node* node = nodeList->item(nodeIdx);
+                toElement(node)->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);

[abarth-chromium, 2014/06/21 05:38:36]

This all looks like something that could be better implemented using
blink-in-js...

+            }
+
+            return;
+        }
+    }
+}
+
 bool Document::hasFocus() const
 {
     Page* page = this->page();
     if (!page)
         return false;
     if (!page->focusController().isActive() || !page->focusController().isFocused())
         return false;
     Frame* focusedFrame = page->focusController().focusedFrame();
     if (focusedFrame && focusedFrame->isLocalFrame()) {
         if (toLocalFrame(focusedFrame)->tree().isDescendantOf(frame()))
@@ skipping 126 matching lines @@
     visitor->trace(m_compositorPendingAnimations);
     visitor->trace(m_contextDocument);
     visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
     DocumentSupplementable::trace(visitor);
     TreeScope::trace(visitor);
     ContainerNode::trace(visitor);
     ExecutionContext::trace(visitor);
 }
 
 } // namespace WebCore