Navigation transitions: Added notifyTransitionsShown and setupTransitionsView to WebLocalFrame

public/web/WebFrame.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 453 matching lines @@
     // current selection is editable, the new selection will be restricted to
     // the root editable element.
     virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent) = 0;
     virtual void moveCaretSelection(const WebPoint&) = 0;
 
     virtual bool setEditableSelectionOffsets(int start, int end) = 0;
     virtual bool setCompositionFromExistingText(int compositionStart, int compositionEnd, const WebVector<WebCompositionUnderline>& underlines) = 0;
     virtual void extendSelectionAndDelete(int before, int after) = 0;
 
     virtual void addStyleSheetByURL(const WebString& url) = 0;
+    virtual void notifyTransitionShown(int elementsToHide) = 0;
+    virtual void setupTransitionView(const WebString& markup) = 0;

[abarth-chromium, 2014/06/13 17:29:01]

I'm not sure this is the right way to load this content into the frame.

Rather than replacing the content of the document (always dicey), you should
trigger a navigation of the frame to a new document with replacement data
consisting of your markup.  Specifically, I think you want to call something
like WebFrame::loadHTMLString.  Perhaps a function like
WebFrame::loadTransitionHTML that calls WebFrame::loadData under the hood, like
WebFrame::loadHTMLString calls WebFrame::loadData?  Notice that
WebFrame::loadData loads the data via the FrameLoader so that the rest of the
system works correctly.

[dcheng, 2014/06/18 18:12:17]

I don't think you'd ever want to call this on a remote frame? As such, I think
it'd be more appropriate to only add this API to WebLocalFrame.h.

[oystein (OOO til 10th of July), 2014/06/18 23:37:42]

Done.

[oystein (OOO til 10th of July), 2014/06/18 23:37:42]

Done! Right now I just call loadData() from setupTransitionView() though, should
it be moved to some intermediate function?

 
     virtual void setCaretVisible(bool) = 0;
 
     // Printing ------------------------------------------------------------
 
     // Reformats the WebFrame for printing. WebPrintParams specifies the printable
     // content size, paper size, printable area size, printer DPI and print
     // scaling option. If constrainToNode node is specified, then only the given node
     // is printed (for now only plugins are supported), instead of the entire frame.
     // Returns the number of pages that can be printed at the given
@@ skipping 208 matching lines @@
     WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker;
 };
 
 #if BLINK_IMPLEMENTATION
 WebCore::Frame* toWebCoreFrame(WebFrame*);
 #endif
 
 } // namespace blink
 
 #endif