[GOM] Warn when the roll is running behind

[GOM] Warn when the roll is running behind

This change introduces a UI that appears when the last roll
is getting old. The UI is not shown by default to avoid
visual clutter and its visual attribute matches the urgency
(currently 2 levels: warning / urgent).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175634

[Julien - ping for review, 2014-06-04 18:52:52]

This change requires https://codereview.chromium.org/316033002/

[ojan, 2014-06-04 18:55:39]

On 2014/06/04 at 18:52:52, jchaffraix wrote:
> This change requires https://codereview.chromium.org/316033002/

I assume you meant some other change?

[Julien - ping for review, 2014-06-04 18:58:18]

On 2014/06/04 18:55:39, ojan wrote:
> On 2014/06/04 at 18:52:52, jchaffraix wrote:
> > This change requires https://codereview.chromium.org/316033002/
> 
> I assume you meant some other change?

Oups, it should have been https://codereview.chromium.org/314913002/

[ojan, 2014-06-04 19:58:40]

Needs a test. Otherwise, just some nits.

https://codereview.chromium.org/316033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/ui.js (right):

https://codereview.chromium.org/316033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/ui.js:360: return { backgroundColor: "red",
fontSize: "3em" };
Nit: can we use the buildbot colors for consistency?

#ffc343 for orange
#e98080 for red

Can we make it blink too? Just for fun. :)

Also, can we use classNames and rules in style-sheets for this instead?

https://codereview.chromium.org/316033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/ui.js:376: wrapper.style.fontSize =
wrapperStyle.fontSize;
Ditto on the using stylesheets thing.

[Julien - ping for review, 2014-06-05 23:20:53]

Added some tests for the new code.

https://codereview.chromium.org/316033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/ui.js (right):

https://codereview.chromium.org/316033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/ui.js:360: return { backgroundColor: "red",
fontSize: "3em" };
On 2014/06/04 19:58:40, ojan wrote:
> Nit: can we use the buildbot colors for consistency?
> 
> #ffc343 for orange
> #e98080 for red

Good idea!

> Can we make it blink too? Just for fun. :)

I was going to agree as it's fun but then I thought about it: we are trying to
_improve_ the usability of the tool. There is a reason why <blink> died and
that's because it introduces a lot of visual distraction. What we want is just
visual contrast and that's what we have with the existing change.

> Also, can we use classNames and rules in style-sheets for this instead?

Good idea!

https://codereview.chromium.org/316033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/ui.js:376: wrapper.style.fontSize =
wrapperStyle.fontSize;
On 2014/06/04 19:58:40, ojan wrote:
> Ditto on the using stylesheets thing.

Done.

[ojan, 2014-06-06 03:16:03]

lgtm

Thanks for improving the tool!

[ojan, 2014-06-06 03:16:06]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-06-06 03:16:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/316033002/30001

[commit-bot: I haz the power, 2014-06-06 04:01:37]

Change committed as 175634