Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/extensions/extension_browsertests_misc.cc

Issue 316018: Fix crash with page actions without icons (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_page_actions_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browsertests_misc.cc
===================================================================
--- chrome/browser/extensions/extension_browsertests_misc.cc (revision 29714)
+++ chrome/browser/extensions/extension_browsertests_misc.cc (working copy)
@@ -207,7 +207,13 @@
#if defined(OS_WIN) || defined(OS_LINUX)
// Tests that we can load page actions in the Omnibox.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, PageAction) {
+ // This page action will not show an icon, since it doesn't specify one but
+ // is included here to test for a crash (http://crbug.com/25562).
ASSERT_TRUE(LoadExtension(
+ test_data_dir_.AppendASCII("browsertest")
+ .AppendASCII("crash_25562")));
+
+ ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("samples")
.AppendASCII("subscribe_page_action")));
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_page_actions_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698