Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 316013007: Fix race condition in gamepad that prevents it to work without a rAF loop (Closed)

Created:
6 years, 6 months ago by kbalazs
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix race condition in gamepad that prevents it to work without a rAF loop GamepadSharedMemoryReader checks for user gesture. But it only does that when someone actually calls SampleGamepads, so in case that does not happen periodically we will miss it. The browser side already has the logic to detect user interaction so let's rely on that. BUG=380870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M content/renderer/gamepad_shared_memory_reader.cc View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kbalazs
6 years, 6 months ago (2014-06-04 21:53:51 UTC) #1
bajones
Non-owner LGTM. Thanks for catching this edge case. I think most people will use the ...
6 years, 6 months ago (2014-06-04 22:00:58 UTC) #2
kbalazs
Can I get an owner review, please.
6 years, 6 months ago (2014-06-13 00:12:02 UTC) #3
jam
lgtm
6 years, 6 months ago (2014-06-13 17:06:53 UTC) #4
kbalazs
The CQ bit was checked by b.kelemen@samsung.com
6 years, 6 months ago (2014-06-13 17:19:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/316013007/1
6 years, 6 months ago (2014-06-13 17:20:40 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 20:41:10 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 22:06:15 UTC) #8
Message was sent while issue was closed.
Change committed as 277102

Powered by Google App Engine
This is Rietveld 408576698