Annotate a third-party leak in SettingGetterImplGSettings::LoadAndCheckVersion().

Annotate a third-party leak in SettingGetterImplGSettings::LoadAndCheckVersion().

BUG=380782
R=rvargas@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275479

[earthdok, 2014-06-04 18:44:39]

please take a look

[rvargas (doing something else), 2014-06-06 02:14:42]

Sorry for the delay, and thanks for doing this.

LGTM after a nit.

https://codereview.chromium.org/316013006/diff/1/net/proxy/proxy_config_servi...
File net/proxy/proxy_config_service_linux.cc (right):

https://codereview.chromium.org/316013006/diff/1/net/proxy/proxy_config_servi...
net/proxy/proxy_config_service_linux.cc:820: if
(SchemaExists("org.gnome.system.proxy")) {
nit: there are 4 uses of this string in this file. Do you mind moving it to a
constant on the anon namespace above?

[earthdok, 2014-06-06 13:00:39]

https://codereview.chromium.org/316013006/diff/1/net/proxy/proxy_config_servi...
File net/proxy/proxy_config_service_linux.cc (right):

https://codereview.chromium.org/316013006/diff/1/net/proxy/proxy_config_servi...
net/proxy/proxy_config_service_linux.cc:820: if
(SchemaExists("org.gnome.system.proxy")) {
On 2014/06/06 02:14:42, rvargas wrote:
> nit: there are 4 uses of this string in this file. Do you mind moving it to a
> constant on the anon namespace above?

Done.

[earthdok, 2014-06-06 13:01:03]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2014-06-06 13:02:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/earthdok@chromium.org/316013006/20001

[commit-bot: I haz the power, 2014-06-06 18:05:53]

Change committed as 275479