Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 316013004: Use Chromium Git mirror for AppRTC (Closed)

Created:
6 years, 6 months ago by kjellander_chromium
Modified:
6 years, 6 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Use Chromium Git mirror for AppRTC AppRTC and the other WebRTC samples have moved to GitHub. In crbug.com/377394 a mirror was setup for it that we can use for the automated tests we have. These modifications will make the change transparent to the test (and hopefully it still passes with the latest version). BUG=362483 TEST=Locally syncing and running hooks and verifying the out/apprtc contains the newly copied files.

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M DEPS View 1 3 chunks +7 lines, -6 lines 0 comments Download
M copy_apprtc.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kjellander_chromium
https://codereview.chromium.org/316013004/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/316013004/diff/1/DEPS#newcode12 DEPS:12: "src/third_party/webrtc-samples": I'm not sure we want to actually put ...
6 years, 6 months ago (2014-06-04 17:13:58 UTC) #1
phoglund_chromium
https://codereview.chromium.org/316013004/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/316013004/diff/1/DEPS#newcode12 DEPS:12: "src/third_party/webrtc-samples": On 2014/06/04 17:13:59, kjellander wrote: > I'm not ...
6 years, 6 months ago (2014-06-05 07:20:59 UTC) #2
kjellander_chromium
PTAL at PS#2. https://codereview.chromium.org/316013004/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/316013004/diff/1/DEPS#newcode12 DEPS:12: "src/third_party/webrtc-samples": On 2014/06/05 07:21:00, phoglund wrote: ...
6 years, 6 months ago (2014-06-05 07:25:36 UTC) #3
phoglund_chromium
Nice work. lgtm!
6 years, 6 months ago (2014-06-05 08:04:26 UTC) #4
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 6 months ago (2014-06-05 08:05:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/316013004/20001
6 years, 6 months ago (2014-06-05 08:05:18 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 08:05:30 UTC) #7
Message was sent while issue was closed.
Change committed as 275043

Powered by Google App Engine
This is Rietveld 408576698