Issue 316005: Quick fix for Alsa stutter - Wake up sooner....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316005: Quick fix for Alsa stutter - Wake up sooner.... (Closed)

Created:
11 years, 2 months ago by fbarchard

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing), awong, Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Quick fix for Alsa stutter - Wake up sooner. BUG=23974 TEST=http://fbarchard-kir.ad.corp.google.com/testmatrix/red/red2.ogv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29761

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	media/audio/linux/alsa_output.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

11 years, 2 months ago (2009-10-22 01:42:30 UTC) #5

LGTM w/ nits

http://codereview.chromium.org/316005/diff/1/2
File media/audio/linux/alsa_output.cc (right):

http://codereview.chromium.org/316005/diff/1/2#newcode632
Line 632: next_fill_time_ms /= 2;   // TODO(fbarchard): Remove this hack.
nit: should have two spaces between ; and //

also it'd be good to file a bug and mention it in the TODO

Expand Messages | Collapse Messages