Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 316005: Quick fix for Alsa stutter - Wake up sooner.... (Closed)

Created:
11 years, 2 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Quick fix for Alsa stutter - Wake up sooner. BUG=23974 TEST=http://fbarchard-kir.ad.corp.google.com/testmatrix/red/red2.ogv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29761

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/audio/linux/alsa_output.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
fbarchard
linux needed to wake up sooner to avoid stutter
11 years, 2 months ago (2009-10-22 01:11:25 UTC) #1
awong
LGTM
11 years, 2 months ago (2009-10-22 01:29:15 UTC) #2
Alpha Left Google
Isn't ajwong already done this before?
11 years, 2 months ago (2009-10-22 01:33:07 UTC) #3
fbarchard
It was his idea :)
11 years, 2 months ago (2009-10-22 01:39:01 UTC) #4
scherkus (not reviewing)
11 years, 2 months ago (2009-10-22 01:42:30 UTC) #5
LGTM w/ nits

http://codereview.chromium.org/316005/diff/1/2
File media/audio/linux/alsa_output.cc (right):

http://codereview.chromium.org/316005/diff/1/2#newcode632
Line 632: next_fill_time_ms /= 2;   // TODO(fbarchard): Remove this hack.
nit: should have two spaces between ; and //

also it'd be good to file a bug and mention it in the TODO

Powered by Google App Engine
This is Rietveld 408576698