Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
316003002:
DevTools: add test to verify matched styles for ::content selector (Closed)
|
Created:
6 years, 6 months ago by lushnikov Modified:
6 years, 6 months ago CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionDevTools: add test to verify matched styles for ::content selector
This patch adds test based on the regression issue with styles sidebar
pane not showing styles for ::contet selectors.
BUG=380414
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175756
Patch Set 1 #Patch Set 2 : rebaseline #
Messages
Total messages: 18 (0 generated)
Please take a look
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/316003002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html: While running svn copy LayoutTests/inspector-protocol/css/css-shadow-host-rule.html LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive --username commit-bot@chromium.org; svn: Path 'LayoutTests/inspector-protocol/css/css-shadow-host-rule.html' does not exist Patch: NR LayoutTests/inspector-protocol/css/css-shadow-host-rule.html->LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html Index: LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html diff --git a/LayoutTests/inspector-protocol/css/css-shadow-host-rule.html b/LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html similarity index 57% copy from LayoutTests/inspector-protocol/css/css-shadow-host-rule.html copy to LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html index dc551accccffecfab1883ac5b3ab61a805e106c3..d720ad21c282d49ae337c288bc1019446c885310 100644 --- a/LayoutTests/inspector-protocol/css/css-shadow-host-rule.html +++ b/LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html @@ -1,3 +1,4 @@ +<!DOCTYPE html> <html> <head> <script type="text/javascript" src="../../http/tests/inspector-protocol/inspector-protocol-test.js"></script> @@ -9,7 +10,7 @@ function test() function onCSSEnabled() { - InspectorTest.requestNodeId("#shadow-host", onNodeReceived); + InspectorTest.requestNodeId("#shadow-content", onNodeReceived); } function onNodeReceived(nodeId) @@ -18,23 +19,17 @@ function test() } } </script> -<template id="shadow-template"> -<style> -:host { - color: red; -} -</style> -<div>Hi!</div> -</template> </head> <body> - <div id="shadow-host"></div> - <script> - var host = document.querySelector("#shadow-host").createShadowRoot(); - var template = document.querySelector("#shadow-template"); - host.appendChild(template.content); - template.remove(); + <div id="shadow-host"> + <p id="shadow-content">This text is bold</p> + </div> + <script type="text/javascript"> + var host = document.querySelector("#shadow-host"); + var root = host.createShadowRoot(); + root.innerHTML = "<style>:host ::content * { font-weight: bold; }</style><content></content>"; runTest(); </script> </body> </html> +
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/316003002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7035) linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...) mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/316003002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/316003002/20001
Message was sent while issue was closed.
Change committed as 175756 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
