Issue 316003: Do not lower our ready state if the media resource is completely loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316003: Do not lower our ready state if the media resource is completely loaded. (Closed)

Created:
11 years, 2 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Do not lower our ready state if the media resource is completely loaded. If the media resource is a file:// we can always report that we have enough data to play the file. We end up passing a bunch of layout tests. BUG=13907 TEST=more layout tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29753

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	webkit/glue/webmediaplayer_impl.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

ping -- sorry I'm in a layout test fixing mood ;)

11 years, 2 months ago (2009-10-22 01:58:35 UTC) #2

LGTM.

Expand Messages | Collapse Messages