Issue 3160025: Revert 56522 - Fix leaks in GoogleURLTrackerTest::CreateRequestContext()...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3160025: Revert 56522 - Fix leaks in GoogleURLTrackerTest::CreateRequestContext()... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by TVL

Modified:
4 years ago

Reviewers:
stuartmorgan, ukai

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 56522 - Fix leaks in GoogleURLTrackerTest::CreateRequestContext() URLFetcher will release URLRequestContextGetter in CancelURLRequest, which runs in IOMessageLoopProxy. So, if a test doesn't run with IO thread, it will not run CancelURLRequest from URLFetcher::Core::Stop(). BUG=52562 TEST=./tools/valgrind/chrome_tests.sh --test unit --tool memcheck --gtest_filter='GoogleURLTrackerTest.*' Review URL: http://codereview.chromium.org/3198001 TBR=ukai@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56543

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	chrome/browser/google_url_tracker_unittest.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download
	M	chrome/common/net/test_url_fetcher_factory.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

needed to revert to revert 56483 since it caused io perf regressions.

4 years, 9 months ago (2010-08-18 17:05:53 UTC) #2

stuartmorgan

4 years, 9 months ago (2010-08-18 17:19:24 UTC) #3

It also appeared to be the cause of leak assertions in
AutomatedUITestBase.RestoreTab on Linux:

[26239:26249:4253367069779:ERROR:./base/leak_tracker.h(93)] Leaked 0x915ed14
which was allocated by:
[26239:26249:4253367069855:ERROR:./base/leak_tracker.h(94)] Backtrace:
	StackTrace::StackTrace() [0x4034aa72]
	base::LeakTracker<>::LeakTracker() [0x4178eec4]
	URLRequest::URLRequest() [0x4178bd40]
	(anonymous namespace)::OCSPRequestSession::StartURLRequest() [0x4170afdc]
	DispatchToMethod<>() [0x4170d483]
	RunnableMethod<>::Run() [0x4170d405]
	MessageLoop::RunTask() [0x403670d7]
	MessageLoop::DeferOrRunPendingTask() [0x40367187]
	MessageLoop::DoWork() [0x40367679]
	base::MessagePumpLibevent::Run() [0x403ced07]
	MessageLoop::RunInternal() [0x40366900]
	MessageLoop::RunHandler() [0x403667db]
	MessageLoop::Run() [0x4036677f]
	base::Thread::Run() [0x4039b6a3]
	base::Thread::ThreadMain() [0x4039b7e9]
	ThreadFunc() [0x4037a56a]
	start_thread [0x4652a80e]
	0x46f148de

[26239:26249:4253367083765:FATAL:./base/leak_tracker.h(97)] Check failed: 0u ==
count (0 vs. 1)
Backtrace:
	StackTrace::StackTrace() [0x4034aa72]
	logging::LogMessage::~LogMessage() [0x40364a6e]
	base::LeakTracker<>::CheckForLeaks() [0x42d022b5]
	IOThread::CleanUp() [0x42d01323]
	base::Thread::ThreadMain() [0x4039b801]
	ThreadFunc() [0x4037a56a]
	start_thread [0x4652a80e]
	0x46f148de

Expand Messages | Collapse Messages