Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3585)

Unified Diff: chrome/browser/google_url_tracker_unittest.cc

Issue 3160025: Revert 56522 - Fix leaks in GoogleURLTrackerTest::CreateRequestContext()... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/net/test_url_fetcher_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_url_tracker_unittest.cc
===================================================================
--- chrome/browser/google_url_tracker_unittest.cc (revision 56542)
+++ chrome/browser/google_url_tracker_unittest.cc (working copy)
@@ -70,14 +70,13 @@
class GoogleURLTrackerTest : public testing::Test {
protected:
GoogleURLTrackerTest()
- : message_loop_(MessageLoop::TYPE_IO),
- io_thread_(ChromeThread::IO, &message_loop_),
- original_default_request_context_(NULL) {
+ : original_default_request_context_(NULL) {
}
void SetUp() {
original_default_request_context_ = Profile::GetDefaultRequestContext();
Profile::set_default_request_context(NULL);
+ message_loop_ = new MessageLoop(MessageLoop::TYPE_IO);
network_change_notifier_.reset(net::NetworkChangeNotifier::CreateMock());
testing_profile_.reset(new TestingProfile);
TestingBrowserProcess* testing_browser_process =
@@ -100,6 +99,7 @@
testing_browser_process->SetPrefService(NULL);
testing_profile_.reset();
network_change_notifier_.reset();
+ delete message_loop_;
Profile::set_default_request_context(original_default_request_context_);
}
@@ -214,8 +214,7 @@
}
private:
- MessageLoop message_loop_;
- ChromeThread io_thread_;
+ MessageLoop* message_loop_;
scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_;
scoped_ptr<TestingProfile> testing_profile_;
« no previous file with comments | « no previous file | chrome/common/net/test_url_fetcher_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698