Issue 3160022: AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes in official build...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3160022: AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes in official build... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by GeorgeY

Modified:
3 years, 11 months ago

Reviewers:
rohitrao (OOO until 6-22), dhollowa

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes in official builds BUG=50537 TEST=In the bug: unit test should work on any brand. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56435

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -43 lines)			Patch
M	chrome/browser/autofill/autofill_manager.h	View	1	4 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_manager.cc	View		4 chunks	+10 lines, -6 lines	2 comments	Download
M	chrome/browser/autofill/autofill_manager_unittest.cc	View		23 chunks	+38 lines, -36 lines	0 comments	Download

Trybot results: win linux mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

LGTM with one request to log follow up bug. http://codereview.chromium.org/3160022/diff/5001/6001 File chrome/browser/autofill/autofill_manager.cc (right): http://codereview.chromium.org/3160022/diff/5001/6001#newcode455 chrome/browser/autofill/autofill_manager.cc:455: ...

4 years, 9 months ago (2010-08-17 20:44:02 UTC) #2

GeorgeY

4 years, 9 months ago (2010-08-17 21:18:46 UTC) #3

http://codereview.chromium.org/3160022/diff/5001/6001
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3160022/diff/5001/6001#newcode455
chrome/browser/autofill/autofill_manager.cc:455: // if
(!disable_download_manager_requests_)
On 2010/08/17 20:44:02, dhollowa wrote:
> Please log an M7 bug on this and add bug reference here.

Done: #52501

Expand Messages | Collapse Messages