Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 3160002: Error reporting for sync setup failure. (Closed)

Created:
10 years, 4 months ago by Raghu Simha
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, Paweł Hajdan Jr.
Visibility:
Public.

Description

Error reporting for sync setup failure. The setup step in the sync integration tests sometimes fails on builders due to timing or networking issues. The tests, however, do not report the exact cause of failure. (Setup can fail due to a number of reasons). Adding some logging that will help debug test failures. BUG=51741 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/test/live_sync/live_sync_test.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/test/live_sync/profile_sync_service_test_harness.cc View 2 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
Can I get a quick CR for this? The mac builder for the sync tests ...
10 years, 4 months ago (2010-08-11 00:13:24 UTC) #1
tim (not reviewing)
10 years, 4 months ago (2010-08-11 00:21:59 UTC) #2
On 2010/08/11 00:13:24, rsimha wrote:
> Can I get a quick CR for this? The mac builder for the sync tests is failing
> during setup, and I'd like to add to the failure logging.
> 
> Thanks!
LGTM

Powered by Google App Engine
This is Rietveld 408576698