Issue 3160002: Error reporting for sync setup failure.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3160002: Error reporting for sync setup failure. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Raghu Simha

Modified:
4 years ago

Reviewers:
timsteele

CC:
chromium-reviews, Raghu Simha, ncarter, idana, Paweł Hajdan Jr.

Visibility:
Public.

Description

Error reporting for sync setup failure. The setup step in the sync integration tests sometimes fails on builders due to timing or networking issues. The tests, however, do not report the exact cause of failure. (Setup can fail due to a number of reasons). Adding some logging that will help debug test failures. BUG=51741 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55645

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -20 lines)			Patch
	M	chrome/test/live_sync/live_sync_test.cc	View		2 chunks	+5 lines, -8 lines	0 comments	Download
	M	chrome/test/live_sync/profile_sync_service_test_harness.cc	View		2 chunks	+9 lines, -12 lines	0 comments	Download

Trybot results: linux win mac

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Raghu Simha

Can I get a quick CR for this? The mac builder for the sync tests ...

4 years, 9 months ago (2010-08-11 00:13:24 UTC) #1

timsteele

4 years, 9 months ago (2010-08-11 00:21:59 UTC) #2

On 2010/08/11 00:13:24, rsimha wrote:
> Can I get a quick CR for this? The mac builder for the sync tests is failing
> during setup, and I'd like to add to the failure logging.
> 
> Thanks!
LGTM

Expand Messages | Collapse Messages