Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 315963003: Switch Chromium to new Skia SkCanvas::drawPicture method (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Switch Chromium to new Skia SkCanvas::drawPicture method As of Skia 9b14f26d (Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) - https://codereview.chromium.org/313613004) SkCanvas::drawPicture has an alternate signature. The old entry point is deprecated. Note: this patch cannot be landed until the corresponding Skia change is rolled into Chromium & Blink. enne: cc fmalita: skia Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275155

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review comment (fix benchmasking_canvas override) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M cc/resources/skpicture_content_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/benchmarking_canvas.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M skia/ext/pixel_ref_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-04 14:17:13 UTC) #1
f(malita)
https://codereview.chromium.org/315963003/diff/1/skia/ext/benchmarking_canvas.cc File skia/ext/benchmarking_canvas.cc (right): https://codereview.chromium.org/315963003/diff/1/skia/ext/benchmarking_canvas.cc#newcode117 skia/ext/benchmarking_canvas.cc:117: virtual void drawPicture(const SkPicture* picture) OVERRIDE { Override onDrawPicture() ...
6 years, 6 months ago (2014-06-04 15:16:55 UTC) #2
robertphillips
https://codereview.chromium.org/315963003/diff/1/skia/ext/benchmarking_canvas.cc File skia/ext/benchmarking_canvas.cc (right): https://codereview.chromium.org/315963003/diff/1/skia/ext/benchmarking_canvas.cc#newcode117 skia/ext/benchmarking_canvas.cc:117: virtual void drawPicture(const SkPicture* picture) OVERRIDE { On 2014/06/04 ...
6 years, 6 months ago (2014-06-04 15:42:41 UTC) #3
f(malita)
lgtm
6 years, 6 months ago (2014-06-04 16:00:29 UTC) #4
enne (OOO)
lgtm Can you update your patch description to wrap at 72 columns?
6 years, 6 months ago (2014-06-04 17:45:31 UTC) #5
robertphillips
wrapped
6 years, 6 months ago (2014-06-04 17:49:17 UTC) #6
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-05 11:58:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/315963003/20001
6 years, 6 months ago (2014-06-05 11:59:32 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 16:35:43 UTC) #9
Message was sent while issue was closed.
Change committed as 275155

Powered by Google App Engine
This is Rietveld 408576698