Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 315923003: DevTools: Tests for DevToolsAndroidBridge device polling (Closed)

Created:
6 years, 6 months ago by vkuzkokov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added test for non-Android devices #

Total comments: 2

Patch Set 3 : Removed unnecessary scoped_ptr #

Patch Set 4 : Added missing overrides #

Patch Set 5 : overrides #

Unified diffs Side-by-side diffs Delta from patch set Stats (+844 lines, -252 lines) Patch
A chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 2 3 4 1 chunk +843 lines, -0 lines 0 comments Download
D chrome/browser/devtools/device/usb/devtools_android_bridge_browsertest.cc View 1 chunk +0 lines, -251 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
vkuzkokov
6 years, 6 months ago (2014-06-04 13:20:42 UTC) #1
Vladislav Kaznacheev
lgtm with comment addressed. https://codereview.chromium.org/315923003/diff/20001/chrome/browser/devtools/device/usb/android_usb_browsertest.cc File chrome/browser/devtools/device/usb/android_usb_browsertest.cc (right): https://codereview.chromium.org/315923003/diff/20001/chrome/browser/devtools/device/usb/android_usb_browsertest.cc#newcode803 chrome/browser/devtools/device/usb/android_usb_browsertest.cc:803: scoped_ptr<MockCountListener> listener(new MockCountListener(adb_bridge_)); Is there ...
6 years, 6 months ago (2014-06-17 10:27:16 UTC) #2
vkuzkokov
https://codereview.chromium.org/315923003/diff/20001/chrome/browser/devtools/device/usb/android_usb_browsertest.cc File chrome/browser/devtools/device/usb/android_usb_browsertest.cc (right): https://codereview.chromium.org/315923003/diff/20001/chrome/browser/devtools/device/usb/android_usb_browsertest.cc#newcode803 chrome/browser/devtools/device/usb/android_usb_browsertest.cc:803: scoped_ptr<MockCountListener> listener(new MockCountListener(adb_bridge_)); On 2014/06/17 10:27:16, Vladislav Kaznacheev wrote: ...
6 years, 6 months ago (2014-06-17 13:01:44 UTC) #3
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-17 13:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/315923003/40001
6 years, 6 months ago (2014-06-17 13:02:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 16:19:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/39982)
6 years, 6 months ago (2014-06-17 16:19:30 UTC) #7
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-17 16:52:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/315923003/40001
6 years, 6 months ago (2014-06-17 16:52:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 23:54:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/35257)
6 years, 6 months ago (2014-06-17 23:54:46 UTC) #11
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-18 07:44:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/315923003/60001
6 years, 6 months ago (2014-06-18 07:46:21 UTC) #13
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-18 10:31:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/315923003/80001
6 years, 6 months ago (2014-06-18 10:32:36 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 15:07:03 UTC) #16
Message was sent while issue was closed. 
Change committed as 278073

Powered by Google App Engine
This is Rietveld 408576698