Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/browser/extensions/permissions_apitest.cc

Issue 3159046: Revert 57540 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/permissions/nacl_enabled/background.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 #include "chrome/common/chrome_switches.h" 6 #include "chrome/common/chrome_switches.h"
7 7
8 class ExperimentalApiTest : public ExtensionApiTest { 8 class ExperimentalApiTest : public ExtensionApiTest {
9 public: 9 public:
10 void SetUpCommandLine(CommandLine* command_line) { 10 void SetUpCommandLine(CommandLine* command_line) {
(...skipping 24 matching lines...) Expand all
35 // tab id as an argument. So, we need the tab permission to get 35 // tab id as an argument. So, we need the tab permission to get
36 // a tab id. 36 // a tab id.
37 ASSERT_TRUE(RunExtensionTest("permissions/experimental_disabled")) 37 ASSERT_TRUE(RunExtensionTest("permissions/experimental_disabled"))
38 << message_; 38 << message_;
39 } 39 }
40 40
41 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FavIconPermission) { 41 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FavIconPermission) {
42 ASSERT_TRUE(RunExtensionTest("permissions/favicon")) << message_; 42 ASSERT_TRUE(RunExtensionTest("permissions/favicon")) << message_;
43 } 43 }
44 44
45 // TODO(gregoryd): run the NaCl test on all systems once
46 // http://code.google.com/p/chromium/issues/detail?id=51335 is fixed.
47 // Meanwhile we run it on Mac OSX only, since we can be sure that an x86-32 NaCl
48 // module will work there.
49 // Mark as Flaky. http://crbug.com/51861
45 #if defined(OS_MACOSX) 50 #if defined(OS_MACOSX)
46 // Mark as Flaky. http://crbug.com/51861
47 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_NaClPermissionEnabled) { 51 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_NaClPermissionEnabled) {
48 #else
49 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, NaClPermissionEnabled) {
50 #endif
51 ASSERT_TRUE(RunExtensionTest("permissions/nacl_enabled")) << message_; 52 ASSERT_TRUE(RunExtensionTest("permissions/nacl_enabled")) << message_;
52 } 53 }
54 #endif
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/permissions/nacl_enabled/background.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698