chromeos: Only look for plugins in Chrome's directory.

chromeos: Only look for plugins in Chrome's /opt directory.

Per discussion with Zelidrag, Chrome OS puts all of its
plugins in /opt/google/chrome/plugins, so we can skip
looking anywhere outside of there.

Embarrassingly, I also missed the Plugins subdirectory of
the user data dir in my previous change.

BUG=chromium-os:4194
TEST=tried it on a Chrome OS machine

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57448

[Evan Martin, 2010-08-25 23:24:49]

I wonder if it'd be more reliable to just stub out the AddExtraPluginDir() call
completely.  And similarly for making the caller skip the function that computes
that monster list of plugins for linux -- you could just provide a separate impl
for chromeos.

LGTM in any case, depends on how much of a rush you're in

[Daniel Erat, 2010-08-26 00:22:30]

Thanks, this seems safer to me too.  I've #if-ed out the bodies of
PluginList::AddExtraPluginPath() and PluginList::AddExtraPluginDir()
for Chrome OS.  I think I'll probably just continue to use the
existing implementation of PluginList::GetPluginDirectories() instead
of adding a separate version; it's pretty easy to just continue
skipping everything after the only directory that we want to use.

On Wed, Aug 25, 2010 at 4:24 PM,  <evan@chromium.org> wrote:
> I wonder if it'd be more reliable to just stub out the AddExtraPluginDir()
> call
> completely.  And similarly for making the caller skip the function that
> computes
> that monster list of plugins for linux -- you could just provide a separate
> impl
> for chromeos.
>
> LGTM in any case, depends on how much of a rush you're in
>
> http://codereview.chromium.org/3159040/show
>

[Evan Martin, 2010-08-26 00:24:33]

LGTM

http://codereview.chromium.org/3159040/diff/6001/7001
File webkit/glue/plugins/plugin_list.cc (right):

http://codereview.chromium.org/3159040/diff/6001/7001#newcode48
webkit/glue/plugins/plugin_list.cc:48: #if !defined(OS_CHROMEOS)
Can you put a comment on this, something like "we only support one plugin path".
 Also below.

[Daniel Erat, 2010-08-26 02:06:13]

http://codereview.chromium.org/3159040/diff/6001/7001
File webkit/glue/plugins/plugin_list.cc (right):

http://codereview.chromium.org/3159040/diff/6001/7001#newcode48
webkit/glue/plugins/plugin_list.cc:48: #if !defined(OS_CHROMEOS)
On 2010/08/26 00:24:33, Evan Martin wrote:
> Can you put a comment on this, something like "we only support one plugin
path".
>  Also below.

Done.