Issue 315863003: Propagate the status in ServiceWorkerURLRequestJob::OnReadCompleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315863003: Propagate the status in ServiceWorkerURLRequestJob::OnReadCompleted (Closed)

Created:
6 years, 6 months ago by horo

Modified:
6 years, 6 months ago

Reviewers:
falken

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Propagate the status in ServiceWorkerURLRequestJob::OnReadCompleted In current code, while reading a blob created by XMLHttpRequest, the status is set to IO_PENDING in ServiceWorkerURLRequestJob::ReadRawData. But the status will not be updated even when complete reading. So DCHECK(!request_->status().is_io_pending()) fails while reading the next chunk. The status must be updated in OnReadCompleted. BUG=382311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275995