mojo/service_manager/service_manager.cc - Issue 315863002: Fix destruction tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/service_manager/service_manager.cc

Issue 315863002: Fix destruction tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/service_manager/service_manager.cc

diff --git a/mojo/service_manager/service_manager.cc b/mojo/service_manager/service_manager.cc

index 114f706e9570ae78adc755bd3353e7764597ed04..b6135181c2adfd72946098c1de7a506f54279d54 100644

--- a/mojo/service_manager/service_manager.cc

+++ b/mojo/service_manager/service_manager.cc

@@ -185,7 +185,9 @@ void ServiceManager::OnServiceFactoryError(ServiceFactory* service_factory) {

DCHECK(it != url_to_service_factory_.end());

delete it->second;

url_to_service_factory_.erase(it);

- GetLoaderForURL(url)->OnServiceError(this, url);

+ ServiceLoader* loader = GetLoaderForURL(url);

+ if (loader)

+ loader->OnServiceError(this, url);

}

} // namespace mojo

« no previous file with comments | « no previous file | mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc » ('j') | no next file with comments »