rebaseline_server: cleanup of HTML/Javascript

rebaseline_server: cleanup of HTML/Javascript

No behavioral change at all.
(SkipBuildbotRuns)

R=borenet@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11946

[epoger, 2013-10-23 20:10:31]

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (left):

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:123: // TODO(epoger): Rather than
maintaining these as hard-coded
Combined these functions into generic versions and moved them near the bottom of
this file.

[borenet, 2013-10-23 20:31:45]

Nice! LGTM with question.

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:167: }
Why is this helper function necessary?

[epoger, 2013-10-24 15:37:16]

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:167: }
On 2013/10/23 20:31:46, borenet wrote:
> Why is this helper function necessary?

Great question.  I didn't know why, but by asking you forced me to actually
learn something.  Added a TODO explaining why.

[epoger, 2013-10-24 15:38:29]

Committed patchset #2 manually as r11946 (presubmit successful).

[borenet, 2013-10-28 12:57:09]

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/31583007/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:167: }
On 2013/10/24 15:37:17, epoger wrote:
> On 2013/10/23 20:31:46, borenet wrote:
> > Why is this helper function necessary?
> 
> Great question.  I didn't know why, but by asking you forced me to actually
> learn something.  Added a TODO explaining why.

Thanks for explaining. I don't think this is a TODO though, unless you have a
workaround in mind. I think it's fine to leave as-is.