Parse the mirror response header.

Parse the mirror response header.

This CL restructures the code in |signin_header_helper.cc| to better support iOS.
It parses the mirror response header on the IO thread and posts the manage
accounts task on the main thread only if the header contains a GAIA action.

BUG=380322
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274800

[msarda, 2014-06-03 21:31:41]

Please take a look.

[Roger Tawa OOO till Jul 10th, 2014-06-04 00:20:49]

lgtm

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
File chrome/browser/signin/signin_header_helper.cc (right):

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.cc:86: const signin::GAIAServiceType&
gaia_service_type) {
Why a reference?

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.cc:205: header_value);
nit: better to wrap like this?

MirrorResponseHeaderDictionary header_dictionary =
    ParseMirrorResponseHeader(header_value);

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.cc:209:
GetGAIAServiceTypeFromHeader(header_dictionary["action"]);
Better to reverse condition?

if (header_dictionary.count("action") > 0) {
  params.service_type =
      GetGAIAServiceTypeFromHeader(header_dictionary["action"]);
}

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
File chrome/browser/signin/signin_header_helper.h (right):

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.h:50: // Returns true if the mirror
header was added to the request.
mirror --> account management

[msarda, 2014-06-04 00:43:29]

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
File chrome/browser/signin/signin_header_helper.cc (right):

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.cc:86: const signin::GAIAServiceType&
gaia_service_type) {
On 2014/06/04 00:20:49, Roger Tawa wrote:
> Why a reference?

Done.

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.cc:205: header_value);
On 2014/06/04 00:20:49, Roger Tawa wrote:
> nit: better to wrap like this?
> 
> MirrorResponseHeaderDictionary header_dictionary =
>     ParseMirrorResponseHeader(header_value);

Done.

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.cc:209:
GetGAIAServiceTypeFromHeader(header_dictionary["action"]);
On 2014/06/04 00:20:49, Roger Tawa wrote:
> Better to reverse condition?
> 
> if (header_dictionary.count("action") > 0) {
>   params.service_type =
>       GetGAIAServiceTypeFromHeader(header_dictionary["action"]);
> }

Done.

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
File chrome/browser/signin/signin_header_helper.h (right):

https://codereview.chromium.org/315773002/diff/60001/chrome/browser/signin/si...
chrome/browser/signin/signin_header_helper.h:50: // Returns true if the mirror
header was added to the request.
On 2014/06/04 00:20:49, Roger Tawa wrote:
> mirror --> account management

Done.

[msarda, 2014-06-04 00:46:07]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2014-06-04 00:46:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msarda@chromium.org/315773002/120001

[msarda, 2014-06-04 01:18:07]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2014-06-04 01:19:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msarda@chromium.org/315773002/140001

[commit-bot: I haz the power, 2014-06-04 05:00:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-04 05:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 05:19:08]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[msarda, 2014-06-04 11:39:17]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2014-06-04 11:39:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msarda@chromium.org/315773002/140001

[commit-bot: I haz the power, 2014-06-04 13:06:52]

Change committed as 274800