Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 315733003: Separate BrowserCdmManager from BrowserMediaPlayerManager. (Closed)

Created:
6 years, 6 months ago by xhwang
Modified:
6 years, 6 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, damienv1, gmorgan_chromium.org
Visibility:
Public.

Description

Separate BrowserCdmManager from BrowserMediaPlayerManager. BUG=315312 TEST=Test pages still work. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275695

Patch Set 1 : Copy android/browser_media_player_manager* to cdm/browser_cdm_manager* for easy diff #

Patch Set 2 : Ready for review. Please diff against PS1 for easier life! #

Total comments: 13

Patch Set 3 : comments addressed #

Patch Set 4 : rebase only #

Patch Set 5 : minor fixes #

Patch Set 6 : Put browser_cdm_manager.* in android/ folder. Will move it in the next CL. #

Patch Set 7 : rebase only #

Patch Set 8 : minor fix after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+546 lines, -426 lines) Patch
A content/browser/media/android/browser_cdm_manager.h View 1 2 3 4 5 6 7 1 chunk +125 lines, -0 lines 0 comments Download
A content/browser/media/android/browser_cdm_manager.cc View 1 2 3 4 5 1 chunk +294 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 2 3 4 5 6 7 8 chunks +4 lines, -69 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 8 chunks +0 lines, -270 lines 0 comments Download
M content/browser/media/android/media_web_contents_observer.h View 1 3 chunks +20 lines, -0 lines 0 comments Download
M content/browser/media/android/media_web_contents_observer.cc View 1 2 3 4 5 2 chunks +101 lines, -34 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/android/media_player_manager.h View 1 2 chunks +0 lines, -39 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
xhwang
rebase only
6 years, 6 months ago (2014-06-03 22:37:44 UTC) #1
xhwang
I'll rebase this on jrummell's Promise CL. Other than that, this CL is ready for ...
6 years, 6 months ago (2014-06-03 22:43:08 UTC) #2
ddorwin
Isn't the BUG really http://crbug.com/315312? LGTM % comments. https://codereview.chromium.org/315733003/diff/80001/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/315733003/diff/80001/content/browser/media/android/browser_media_player_manager.cc#newcode9 content/browser/media/android/browser_media_player_manager.cc:9: #include ...
6 years, 6 months ago (2014-06-04 01:02:30 UTC) #3
xhwang
comments addressed
6 years, 6 months ago (2014-06-04 18:49:21 UTC) #4
xhwang
rebase only
6 years, 6 months ago (2014-06-04 18:53:58 UTC) #5
xhwang
https://codereview.chromium.org/315733003/diff/80001/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/315733003/diff/80001/content/browser/media/android/browser_media_player_manager.cc#newcode9 content/browser/media/android/browser_media_player_manager.cc:9: #include "base/stl_util.h" On 2014/06/04 01:02:30, ddorwin wrote: > Do ...
6 years, 6 months ago (2014-06-04 18:54:06 UTC) #6
ddorwin
lgtm
6 years, 6 months ago (2014-06-04 19:12:20 UTC) #7
xhwang
damienv and gmorgan: FYI
6 years, 6 months ago (2014-06-05 00:24:02 UTC) #8
xhwang
rebase only
6 years, 6 months ago (2014-06-07 14:54:15 UTC) #9
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 6 months ago (2014-06-07 15:54:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/315733003/210001
6 years, 6 months ago (2014-06-07 15:54:56 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 20:28:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 275695

Powered by Google App Engine
This is Rietveld 408576698