Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 315713002: Enable unified GR by default in Aura. (Closed)

Created:
6 years, 6 months ago by tdresser
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org, jdduke (slow)
Visibility:
Public.

Description

Enable unified GR by default in Aura. BUG=332418 TEST=GestureRecognizerTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275122

Patch Set 1 #

Patch Set 2 : Fix SimulateTapAt to include a non-zero timestamp on the touch events. #

Total comments: 2

Patch Set 3 : Address phajdan.jr's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/public/test/browser_test_utils.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
tdresser
Pending https://codereview.chromium.org/313473002/ and https://codereview.chromium.org/309823002/
6 years, 6 months ago (2014-06-03 19:09:45 UTC) #1
tdresser
All patches this depends on have landed.
6 years, 6 months ago (2014-06-04 12:01:59 UTC) #2
sadrul
LGTM!!
6 years, 6 months ago (2014-06-04 12:35:07 UTC) #3
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 6 months ago (2014-06-04 12:35:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/315713002/1
6 years, 6 months ago (2014-06-04 12:37:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 16:05:01 UTC) #6
tdresser
The CQ bit was unchecked by tdresser@chromium.org
6 years, 6 months ago (2014-06-04 17:13:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 17:14:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/38292)
6 years, 6 months ago (2014-06-04 17:14:18 UTC) #9
tdresser
phajdan.jr@, can you take a look at the browser_test_utils change? It's just to avoid hitting ...
6 years, 6 months ago (2014-06-04 19:28:35 UTC) #10
Paweł Hajdan Jr.
LGTM with a comment https://codereview.chromium.org/315713002/diff/20001/content/public/test/browser_test_utils.cc File content/public/test/browser_test_utils.cc (right): https://codereview.chromium.org/315713002/diff/20001/content/public/test/browser_test_utils.cc#newcode269 content/public/test/browser_test_utils.cc:269: touch.SetTimestamp(base::TimeTicks::Now() - base::TimeTicks()); nit: Could ...
6 years, 6 months ago (2014-06-05 10:17:53 UTC) #11
tdresser
https://codereview.chromium.org/315713002/diff/20001/content/public/test/browser_test_utils.cc File content/public/test/browser_test_utils.cc (right): https://codereview.chromium.org/315713002/diff/20001/content/public/test/browser_test_utils.cc#newcode269 content/public/test/browser_test_utils.cc:269: touch.SetTimestamp(base::TimeTicks::Now() - base::TimeTicks()); On 2014/06/05 10:17:53, Paweł Hajdan Jr. ...
6 years, 6 months ago (2014-06-05 12:05:08 UTC) #12
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 6 months ago (2014-06-05 12:05:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/315713002/40001
6 years, 6 months ago (2014-06-05 12:06:57 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 14:06:19 UTC) #15
commit-bot: I haz the power
Change committed as 275122
6 years, 6 months ago (2014-06-05 15:05:48 UTC) #16
tdresser
6 years, 6 months ago (2014-06-05 19:16:23 UTC) #17
Message was sent while issue was closed.
On 2014/06/05 15:05:48, I haz the power (commit-bot) wrote:
> Change committed as 275122

Reverted here:
https://codereview.chromium.org/312303003/

Powered by Google App Engine
This is Rietveld 408576698