Issue 3157038: Remove reference to obsolete web preference. The legacy parser no longer...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3157038: Remove reference to obsolete web preference. The legacy parser no longer... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by abarth

Modified:
4 years ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove reference to obsolete web preference. The legacy parser no longer exists so it can't be enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57259

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -18 lines)			Patch
M	webkit/glue/webpreferences.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

LGTM. Could you also check if there are any test scripts in-tree that reference these ...

4 years, 9 months ago (2010-08-24 23:00:37 UTC) #2

abarth

4 years, 9 months ago (2010-08-24 23:40:38 UTC) #3

On 2010/08/24 23:00:37, jamesr wrote:
> LGTM.  Could you also check if there are any test scripts in-tree that
reference
> these flags?

I greped the whole src directory and didn't find anything.

Expand Messages | Collapse Messages