Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Issue 315703002: Add a missing call to NULL-ify the delegate of the AutoEnrollmentScreen. (Closed)

Created:
6 years, 6 months ago by pastarmovj
Modified:
6 years, 6 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add a missing call to NULL-ify the delegate of the AutoEnrollmentScreen. BUG=379996 TEST=manual as descirbed in the bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274872

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
pastarmovj
Please review this CL. Thanks! https://codereview.chromium.org/315703002/diff/1/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h File chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h (left): https://codereview.chromium.org/315703002/diff/1/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h#oldcode39 chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h:39: void HandleOnSkip(); This is ...
6 years, 6 months ago (2014-06-03 18:44:48 UTC) #1
Dmitry Polukhin
lgtm
6 years, 6 months ago (2014-06-03 18:48:00 UTC) #2
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 6 months ago (2014-06-03 19:02:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/315703002/1
6 years, 6 months ago (2014-06-03 19:06:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 00:37:32 UTC) #5
pastarmovj
The CQ bit was checked by pastarmovj@chromium.org
6 years, 6 months ago (2014-06-04 18:21:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/315703002/1
6 years, 6 months ago (2014-06-04 18:23:29 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 18:25:48 UTC) #8
Message was sent while issue was closed.
Change committed as 274872

Powered by Google App Engine
This is Rietveld 408576698