Use WebViewClient instead of BlinkPlatform for screen lock.

Source/modules/screen_orientation/ScreenOrientation.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/screen_orientation/ScreenOrientation.h"
 
 #include "bindings/v8/ScriptPromise.h"
 #include "bindings/v8/ScriptPromiseResolverWithContext.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/frame/DOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Screen.h"
+#include "core/page/Page.h"
 #include "modules/screen_orientation/LockOrientationCallback.h"
 #include "modules/screen_orientation/ScreenOrientationController.h"
-#include "public/platform/Platform.h"
 #include "public/platform/WebScreenOrientationType.h"
 
 // This code assumes that WebScreenOrientationType values are included in WebScreenOrientationLockType.
 #define COMPILE_ASSERT_MATCHING_ENUM(enum1, enum2) \
     COMPILE_ASSERT(static_cast<unsigned>(blink::enum1) == static_cast<unsigned>(blink::enum2), mismatching_types)
 COMPILE_ASSERT_MATCHING_ENUM(WebScreenOrientationPortraitPrimary, WebScreenOrientationLockPortraitPrimary);
 COMPILE_ASSERT_MATCHING_ENUM(WebScreenOrientationPortraitSecondary, WebScreenOrientationLockPortraitSecondary);
 COMPILE_ASSERT_MATCHING_ENUM(WebScreenOrientationLandscapePrimary, WebScreenOrientationLockLandscapePrimary);
 COMPILE_ASSERT_MATCHING_ENUM(WebScreenOrientationLandscapeSecondary, WebScreenOrientationLockLandscapeSecondary);
 
@@ skipping 65 matching lines @@
 }
 
 Document* ScreenOrientation::document() const
 {
     if (!m_associatedDOMWindow || !m_associatedDOMWindow->isCurrentlyDisplayedInFrame())
         return 0;
     ASSERT(m_associatedDOMWindow->document());
     return m_associatedDOMWindow->document();
 }
 
+Page* ScreenOrientation::page() const
+{
+    ASSERT(document()->page());

[Inactive, 2014/06/03 18:04:53]

This seems unsafe. We should probably return 0 if frame() is null.

[mlamouri (slow - plz ping), 2014/06/03 19:49:30]

Done.

+    return document()->page();

[Inactive, 2014/06/03 18:04:53]

We should be able to use frame()->page() since this is a DOMWindowProperty, to
avoid going through the Document.

[mlamouri (slow - plz ping), 2014/06/03 19:49:30]

Done.

+}
+
 ScreenOrientation& ScreenOrientation::from(Screen& screen)
 {
     ScreenOrientation* supplement = static_cast<ScreenOrientation*>(WillBeHeapSupplement<Screen>::from(screen, supplementName()));
     if (!supplement) {
         supplement = new ScreenOrientation(screen);
         provideTo(screen, supplementName(), adoptPtrWillBeNoop(supplement));
     }
     return *supplement;
 }
 
 ScreenOrientation::~ScreenOrientation()
 {
 }
 
 const AtomicString& ScreenOrientation::orientation(Screen& screen)
 {
     ScreenOrientation& screenOrientation = ScreenOrientation::from(screen);
     if (!screenOrientation.document()) {
         // FIXME: we should try to return a better guess, like the latest known value.
         return orientationTypeToString(blink::WebScreenOrientationPortraitPrimary);
     }
-    ScreenOrientationController& controller = ScreenOrientationController::from(*screenOrientation.document());
+    ScreenOrientationController& controller = ScreenOrientationController::from(*screenOrientation.page());
     return orientationTypeToString(controller.orientation());
 }
 
 ScriptPromise ScreenOrientation::lockOrientation(ScriptState* state, Screen& screen, const AtomicString& lockString)
 {
     RefPtr<ScriptPromiseResolverWithContext> resolver = ScriptPromiseResolverWithContext::create(state);
     ScriptPromise promise = resolver->promise();
 
     ScreenOrientation& screenOrientation = ScreenOrientation::from(screen);
     Document* document = screenOrientation.document();
 
     if (!document) {
         RefPtrWillBeRawPtr<DOMException> exception = DOMException::create(InvalidStateError, "The object is no longer associated to a document.");
         resolver->reject(exception);
         return promise;
     }
 
     if (document->isSandboxed(SandboxOrientationLock)) {
         RefPtrWillBeRawPtr<DOMException> exception = DOMException::create(SecurityError, "The document is sandboxed and lacks the 'allow-orientation-lock' flag.");
         resolver->reject(exception);
         return promise;
     }
 
-    blink::Platform::current()->lockOrientation(stringToOrientationLock(lockString), new LockOrientationCallback(resolver));
+    ScreenOrientationController::from(*document->page()).lockOrientation(stringToOrientationLock(lockString), new LockOrientationCallback(resolver));

[Inactive, 2014/06/03 18:04:53]

I think it is possible for page() to return null if we don't have a Frame. Also,
we should probably use ScreenOrientation::page() that you added.

[mlamouri (slow - plz ping), 2014/06/03 19:49:30]

Done.

     return promise;
 }
 
 void ScreenOrientation::unlockOrientation(Screen& screen)
 {
-    blink::Platform::current()->unlockOrientation();
+    ScreenOrientation& screenOrientation = ScreenOrientation::from(screen);
+    if (!screenOrientation.page())

[Inactive, 2014/06/03 18:04:53]

That method currently has an assertion making sure it is not null. I think we
should get rid of that assertion and keep this null check.

[mlamouri (slow - plz ping), 2014/06/03 19:49:30]

Done.

+        return;
+
+    ScreenOrientationController::from(*screenOrientation.page()).unlockOrientation();
 }
 
 } // namespace WebCore