Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 315663006: FrameSelection::textWasReplaced and setSelectedRange shouldn't trigger synchronous layout (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, dglazkov, eseidel, esprehn, ojan
Visibility:
Public.

Description

FrameSelection::textWasReplaced and setSelectedRange shouldn't trigger synchronous layout These synchronous calls to layout aren't necessary. This CL merges http://trac.webkit.org/changeset/164319 by rniwa, which made WebKit go fast on Speedometer. BUG=380173 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M Source/core/editing/FrameSelection.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-03 23:41:16 UTC) #1
eseidel
lgtm
6 years, 6 months ago (2014-06-03 23:43:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/315663006/1
6 years, 6 months ago (2014-06-03 23:43:41 UTC) #3
pdr.
Could you please list the original author in the change description?
6 years, 6 months ago (2014-06-03 23:43:45 UTC) #4
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 6 months ago (2014-06-03 23:44:11 UTC) #5
abarth-chromium
On 2014/06/03 23:43:45, pdr wrote: > Could you please list the original author in the ...
6 years, 6 months ago (2014-06-03 23:44:26 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-03 23:44:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/315663006/1
6 years, 6 months ago (2014-06-03 23:45:26 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 01:44:38 UTC) #9
Message was sent while issue was closed.
Change committed as 175421

Powered by Google App Engine
This is Rietveld 408576698