Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 315663004: [Android] Changing View type for title_button AppMenu items. (Closed)

Created:
6 years, 6 months ago by aurimas (slooooooooow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Changing View type for title_button AppMenu items. Changing the type of Text in title_button_menu_item.xml from Button to TextView to remove additional pressed state background that comes with the Button. BUG=369680 R=dtrainor@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/android/java/res/layout/title_button_menu_item.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aurimas (slooooooooow)
Hey David, Please take a look at this change. Thanks, Aurimas
6 years, 6 months ago (2014-06-03 20:16:55 UTC) #1
David Trainor- moved to gerrit
lgtm
6 years, 6 months ago (2014-06-04 00:31:21 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 6 months ago (2014-06-04 00:33:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/315663004/1
6 years, 6 months ago (2014-06-04 00:35:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 04:27:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 07:22:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/23358)
6 years, 6 months ago (2014-06-04 07:22:28 UTC) #7
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 6 months ago (2014-06-04 14:54:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/315663004/1
6 years, 6 months ago (2014-06-04 14:56:21 UTC) #9
aurimas (slooooooooow)
6 years, 6 months ago (2014-06-04 17:33:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r274856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698