Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 315663003: Disable warning C4702 in logging.cc (Closed)

Created:
6 years, 6 months ago by Sébastien Marchand
Modified:
6 years, 6 months ago
Reviewers:
brettw, Peter Kasting
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable warning C4702 in logging.cc BUG=380175 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274738

Patch Set 1 #

Patch Set 2 : Add a OS_WIN condition #

Patch Set 3 : Add a TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/logging.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Sébastien Marchand
PTAL, we still need to fix the root cause of this but in the meantime ...
6 years, 6 months ago (2014-06-03 18:32:57 UTC) #1
Peter Kasting
LGTM
6 years, 6 months ago (2014-06-03 18:34:09 UTC) #2
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 6 months ago (2014-06-03 18:34:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/315663003/1
6 years, 6 months ago (2014-06-03 18:35:08 UTC) #4
Sébastien Marchand
The CQ bit was unchecked by sebmarchand@chromium.org
6 years, 6 months ago (2014-06-03 18:45:40 UTC) #5
Sébastien Marchand
Putting this behind a "#if defined(OS_WIN)" condition could be a good idea...
6 years, 6 months ago (2014-06-03 18:47:38 UTC) #6
Sébastien Marchand
PTAnL
6 years, 6 months ago (2014-06-03 18:47:51 UTC) #7
Peter Kasting
LGTM It's too bad we can't put this around the EAT_STREAM_PARAMETERS define. I hate the ...
6 years, 6 months ago (2014-06-03 18:51:13 UTC) #8
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 6 months ago (2014-06-03 18:52:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/315663003/20001
6 years, 6 months ago (2014-06-03 18:52:41 UTC) #10
scottmg
It can go in the macro by using __pragma instead of #pragma. I think that ...
6 years, 6 months ago (2014-06-03 18:58:28 UTC) #11
Sébastien Marchand
Yeah, I just wanted to fix this temporarily until we decide on the proper way ...
6 years, 6 months ago (2014-06-03 19:00:32 UTC) #12
Sébastien Marchand
+brettw@ for owner approval
6 years, 6 months ago (2014-06-03 21:36:35 UTC) #13
brettw
lgtm
6 years, 6 months ago (2014-06-03 22:55:19 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:10:13 UTC) #15
Message was sent while issue was closed.
Change committed as 274738

Powered by Google App Engine
This is Rietveld 408576698