Issue 315663002: Fix omnibox focus ring regression on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315663002: Fix omnibox focus ring regression on Windows. (Closed)

Created:
6 years, 6 months ago by Daniel Erat

Modified:
6 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, tfarina, dmazzoni

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix omnibox focus ring regression on Windows. Restore part of LocationBarView::OnFocus(), which was removed by r269418. Otherwise, the omnibox doesn't receive a focus ring on Windows. BUG=380141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274614

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/location_bar/location_bar_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Daniel Erat

Hmm, looks like the OnFocus() override might've been necessary after all. Peter, would you mind ...

6 years, 6 months ago (2014-06-03 14:54:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/315663002/1

6 years, 6 months ago (2014-06-03 18:20:02 UTC) #4

Message was sent while issue was closed.

Change committed as 274614