Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 315643002: Fix etc1 support for SkFiddle. (Closed)

Created:
6 years, 6 months ago by jcgregorio
Modified:
6 years, 6 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix etc1 support for SkFiddle. Also update design doc to fix MySQL notation for auto incrementing columns. BUG=skia: Committed: https://skia.googlesource.com/skia/+/92bfb09ac8a2acad7b62f9431fb8020eaa329ea2

Patch Set 1 #

Patch Set 2 : Fix SQL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M experimental/webtry/DESIGN.md View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/webtry.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jcgregorio
6 years, 6 months ago (2014-06-03 14:25:38 UTC) #1
mtklein
lgtm
6 years, 6 months ago (2014-06-03 14:48:31 UTC) #2
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 6 months ago (2014-06-03 14:50:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/315643002/20001
6 years, 6 months ago (2014-06-03 14:50:58 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 16:04:55 UTC) #5
Message was sent while issue was closed.
Change committed as 92bfb09ac8a2acad7b62f9431fb8020eaa329ea2

Powered by Google App Engine
This is Rietveld 408576698